[move-compiler] Fix a crash when public(package) processing involves pre-compiled modules#25469
Draft
[move-compiler] Fix a crash when public(package) processing involves pre-compiled modules#25469
Conversation
…pre-compiled modules
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
awelc
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
awelc
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In a recent PR we changed how
move-analyzeruses pre-compiled libraries. In particular, some dependency modules from the same package can be passed to the compiler as pre-compiled libs and some can be fully compiled.This exposed a problem fixed in the current PR which is related to updating information related
package(public)in dependency modules. Prior to themove-analyzerchange it was never possible to have some modules from the same package in pre-compiled libs and some fully compiled and for a given fully compiled module it was expected to have all its friend modules also fully compiled (or the compiler would crash)Test plan
Added a new
move-analyzertest that exposed the problem prior to the fix. All tests must pass