fix(move-compiler): prevent panic on assert! with wrong arg count#25471
Open
lau90eth wants to merge 2 commits intoMystenLabs:mainfrom
Open
fix(move-compiler): prevent panic on assert! with wrong arg count#25471lau90eth wants to merge 2 commits intoMystenLabs:mainfrom
lau90eth wants to merge 2 commits intoMystenLabs:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Fixes MystenLabs#25459 The compiler would panic with 'called Result::unwrap() on an Err value' when assert! was called with more than 2 arguments. This happened in hlir/translate.rs when trying to convert the argument list to a fixed-size array of 2 elements. Now it gracefully handles the error and reports a proper diagnostic message instead of crashing. Test case added: bad_assert_args
a74a184 to
0246125
Compare
|
Deployment failed with the following error: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25459
Problem
The Move compiler would panic with
called Result::unwrap() on an Err valuewhenassert!was called with more than 2 arguments.Root Cause
In
hlir/translate.rs, the code used.unwrap()when converting the argument list to a fixed-size array[TI; 2]: