Parallelize bulk_insert_live_objects during snapshot restore#25904
Merged
Parallelize bulk_insert_live_objects during snapshot restore#25904
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
andll
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
andll
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
johnjmartin
reviewed
Mar 20, 2026
johnjmartin
approved these changes
Mar 20, 2026
andll
force-pushed
the
parallel-snapshot-inserts
branch
from
d6848dc to
aef9fbb
Compare
andll
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
andll
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
andll
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
andll
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
andll
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
andll
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
andll
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
andll
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
andll
force-pushed
the
parallel-snapshot-inserts
branch
from
c6b4ebf to
4f8cd07
Compare
andll
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AuthorityStore::bulk_insert_live_objectsto acceptArc<AuthorityPerpetualTables>andVec<LiveObject>(collected at the call site)tokio::task::spawn_blockingStateSnapshotReaderV1::read/sync_live_objectsto propagate theArcand use an asynctry_for_eachclosureTest plan
cargo check -p sui-core -p sui-snapshot -p sui-toolSUI_SKIP_SIMTESTS=1 cargo nextest run -p sui-snapshot🤖 Generated with Claude Code