Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
8aca1df to
bd8ab7a
Compare
bd8ab7a to
a61219e
Compare
a61219e to
b0770b1
Compare
b0770b1 to
85efc3b
Compare
amnn
left a comment
There was a problem hiding this comment.
@phoenix-o, could you motivate your use of the indexing framework here, as well as some of the changes you need to make to it?
- Why does state sync need those changes, and are those needs general to all users of the indexing framework or specific to state sync?
- How much of the indexing framework are you using?
It's possible/likely that the best option is to not use the indexing framework, but implement a small/custom interface over object_store instead that caters exactly to the node software's needs.
|
@amnn: State sync currently uses the old ingestion framework. This PR migrates it(last callsite) and utilizes the new checkpoint format. |
If only
Separately, I think this issue has come up before, so maybe it is worth solving in the framework, even if state sync doesn't use it:
|
|
@amnn: sounds good, I’ll revert the changes to |
85efc3b to
a75e891
Compare
amnn
left a comment
There was a problem hiding this comment.
Thanks @phoenix-o, this is now mostly outside of my domain, so will leave the rest of the review to @bmwill or @nickvikeras
| sui-simulator.workspace = true | ||
| sui-protocol-config.workspace = true | ||
| sui-data-ingestion-core.workspace = true | ||
| sui-indexer-alt-framework.workspace = true |
There was a problem hiding this comment.
Should be able to get rid of this now, right?
Description
migrates state sync to the new bucket format
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.