Skip to content

[consensus] Decouple consensus config from core sui crates#25938

Open
omersadika wants to merge 2 commits intoMystenLabs:mainfrom
omersadika:decouple-consensus-config
Open

[consensus] Decouple consensus config from core sui crates#25938
omersadika wants to merge 2 commits intoMystenLabs:mainfrom
omersadika:decouple-consensus-config

Conversation

@omersadika
Copy link

Description

  • ConsensusProtocolConfig was introduced to decouple consensus from ProtocolConfig (which pulls in sui-protocol-config and the Move VM). Made its API consistent with ProtocolConfig - private fields, getters, set_*_for_testing() setters, and a new() constructor for the Sui code.
  • Also replaced AuthorityPublicKey with AuthorityIdentifier. It was wrapping a BLS12381PublicKey but only used for identity checks, never verification. Now it's just 96 raw bytes, with Sui passing the key bytes instead.

Test plan

  • SUI_SKIP_SIMTESTS=1 cargo test -p consensus-config - 2 passed (including snapshot)
  • SUI_SKIP_SIMTESTS=1 cargo test -p consensus-core - 194 passed
  • SUI_SKIP_SIMTESTS=1 cargo test -p sui-core -- scoring_decision - 1 passed
  • cargo xclippy - clean

Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • gRPC:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:
  • Indexing Framework:

@omersadika omersadika requested a review from a team as a code owner March 21, 2026 16:25
@vercel
Copy link

vercel bot commented Mar 21, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
sui-docs Ready Ready Preview, Comment Mar 21, 2026 4:31pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
multisig-toolkit Ignored Ignored Preview Mar 21, 2026 4:31pm
sui-kiosk Ignored Ignored Preview Mar 21, 2026 4:31pm

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant