Improve private key security #694
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Michael Hayes <[email protected]>
make legacyAddress parameter required Co-authored-by: Michael Hayes <[email protected]>
Co-authored-by: Michael Hayes <[email protected]>
Co-authored-by: Michael Hayes <[email protected]>
remove json rpc exports from @mysten/sui/client Co-authored-by: Michael Hayes <[email protected]>
remove deprecated methdos Co-authored-by: Michael Hayes <[email protected]>
add test coverage for core api methods
* Add include options for core APIs * migrate tests to grpc * PR feedback
Jordan-Mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
hayes-mysten
approved these changes
Dec 1, 2025
hayes-mysten
force-pushed
the
sdk-v2
branch
4 times, most recently
from
fed49bd to
1574ff0
Compare
hayes-mysten
force-pushed
the
sdk-v2
branch
2 times, most recently
from
890c78e to
a75baa4
Compare
hayes-mysten
force-pushed
the
sdk-v2
branch
2 times, most recently
from
d711817 to
e402d34
Compare
hayes-mysten
force-pushed
the
sdk-v2
branch
2 times, most recently
from
b4dd1d3 to
f6b1c31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cherry picking the private key changes from #404.
I realized we were using fake private for the data in keypairs, which kind scares me because if you log a keypair (which IMO seems like an operation that should be plenty safe) it means that all of the secret values are exposed:
Test plan
Tests
AI Assistance Notice