Migrate suins to sdk-v2 by hayes-mysten · Pull Request #743 · MystenLabs/ts-sdks

hayes-mysten · 2025-12-16T23:08:55Z

Description

Describe the changes or additions included in this PR.

Test plan

How did you test the new or updated feature?

AI Assistance Notice

Please disclose the usage of AI. This is primarily to help inform reviewers of how careful they need to review PRs, and to keep track of AI usage across our team. Please fill this out accurately, and do not modify the content or heading for this section!

This PR was primarily written by AI.
I used AI for docs / tests, but manually wrote the source code.
I used AI to understand the problem space / repository.
I did not use AI for this PR.

vercel · 2025-12-16T23:08:59Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Review	Updated (UTC)
sui-typescript-docs	Ready	Preview, Comment	Jan 6, 2026 6:12pm

williamrobertson13

Overall lgtm in re: to the updated transaction building and SDK patterns. I admittedly skimmed through a lot of the codegen + oracle logic 😅

williamrobertson13 · 2026-01-09T00:05:07Z

packages/suins/src/suins-client.ts

-			name: {
-				type: getConfigType(
-					this.config.packageIdV1,
-					getRenewalPricelistConfigType(this.config.packageIdPricing),


do we want to delete any of these helpers in the v2?

We need a bigger rewrite soon, so I was going to leave it for later to keep this migration easier

* Remove default client used for verifying zklogin signatures (#625) Co-authored-by: Michael Hayes <michael@hayes.io> * require legacy address arg (#627) make legacyAddress parameter required Co-authored-by: Michael Hayes <michael@hayes.io> * make network required (#628) Co-authored-by: Michael Hayes <michael@hayes.io> * remove reportTransactionEffects (#630) Co-authored-by: Michael Hayes <michael@hayes.io> * remove asClientExtension * remove sui client exports (#633) remove json rpc exports from @mysten/sui/client Co-authored-by: Michael Hayes <michael@hayes.io> * remove deprecated methods (#634) remove deprecated methdos Co-authored-by: Michael Hayes <michael@hayes.io> * core api tests (#644) add test coverage for core api methods * Export a single graphql schema (#646) * fix fetching package objects * Add transaction resolution support for grpc client (#649) * Add transaction resolution support for grpc client * remove experimental client exports (#650) * remove experimental prefix for core client apis * fix some todos and inconsistencies in the core apis (#654) * Add include options for core APIs (#656) * Add include options for core APIs * migrate tests to grpc * PR feedback * remove eslint (#698) * rename listObjects to getObjects (#696) * move sui sdk to packages/sui (#697) * dApp Kit Next docs (#529) * dApp Kit Next docs * fix links and wording * linting * migration guide improvements & general refactor * remove more hallucinations + fix code (after manual tests) and text (after re-reading) * refactor + add missing global type registration in the migration guide * global type registration comment in react/next-js examples * polish and fixes * Apply suggestions from code review Co-authored-by: William Robertson <williamrobertson13@users.noreply.github.com> * merge dapp-kit-next docs into the old ones; refactor * address PR comments * more pr feedback fixes * restructure docs * fix lint --------- Co-authored-by: William Robertson <williamrobertson13@users.noreply.github.com> Co-authored-by: Michael Hayes <michael.hayes@mystenlabs.com> * Add top level transaction status to transaction response (#702) * Add top level transaction status to transaction response update examples and docs add transaction result type * pr feedback * fix broken test * update create-dapp (#703) * update create-dapp Add codegen docs * PR feedback * rename `Commands` -> `TransactionCommands` to fix react-native ESM resolution (#724) * remove deepbook from changset * Add objectBcs to core API and update signers sdk to work with core cl… (#727) * Add objectBcs to core API and update signers sdk to work with core clients * address PR comments * Migrate more thigns to grpc (#728) * Add commandResults to simulate api (#730) * Add commandResults to simulate api * simulate unresolved transactions * add missing wait for transaction * test fixes * codegen: support on-chain package summary generation Add support for generating code from on-chain packages by using `sui move summary --package-id` to fetch summaries automatically. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * fix packageId normalization issue in tests * Mh less publishing (#739) less package publishing in tests * fix(codegen): preserve original type parameter index when filtering When generic type parameters are filtered (e.g., to exclude phantom parameters), the codegen was incorrectly using the new array index instead of the original index. This caused generated code to reference wrong type parameters (e.g., T1 instead of T0). This fix maps type parameters to `{ param, originalIndex }` before filtering, ensuring the original index is preserved and used in the generated output. Also adds generated BCS contracts for kiosk package. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * Codegen import improvements * fix broken test * fix(codegen): use lowercase module name for object::ID check The module name in the type tag is 'object' (lowercase), not 'Object'. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * chore: regenerate codegen output 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * chore: sync branch histories * update a few examples * [bcs] add map sorting (#747) * make packages esm only (#749) * convert to tsdown and esm only packages * fix deps * cleanup dapp-kit-next build config * update crypto deps * upgrade deepbook to sdk v2 (#731) * upgrade deepbook to sdk v2 * pr feedback * fix some todos * normalize some constants (#753) * remove old subpath package.json files (#752) * export grpc types (#751) * expose core methods on grpc and graphql (#750) * expose core methods on grpc and graphql clients * update examples and docs * accept TransactionResult in waitForTransaction (#746) * remove nesting of uid fields (#745) * fix lint * fix build issue * Remove data fetching helpers from zkSend SDK (#676) * Migrate suins to sdk-v2 (#743) * Update zksend sdk (#769) Update zklogin sdk * update executors to work with core APIs (#744) * Add clever error support (#754) * Add clever error support * pr feedback * Add withdrawal inputs (#768) * fix any * fix rebase * kiosk refactor (#740) * wip - kiosk refactor * transaction building cleanup * add changeset and migration * update schemas * remove entire balance option (#779) * use peer deps for @mysten/sui (#781) * use network instead of env in deepbook sdk (#783) * Improve migration docs (#772) * Improve migration docs * PR feedback * fix lint * fix seal test timeouts * update deps * Add getter to codegen bcs types (#797) * Add address balance support to CoinWithBalance and core API (#773) * Add address balance support to CoinWithBalance and core API * Add json rpc address balances * change expiration default * Add transction resolution for graphql * add graphql address balances * fix rebase * Support address balacnes in executors (#804) * disable gas selection on simulate * dapp-kit css migration docs * docs verification feedback * esm migration doc * fix version bumps * fix bumps for wallet-sdk and wallet-standard * fix lockfile * fix lint * update deps * Add banner * fix audit * Add core include json option (#808) * update seal tests --------- Co-authored-by: Michael Hayes <michael@hayes.io> Co-authored-by: Greg Wróbel <10615866+gwro@users.noreply.github.com> Co-authored-by: William Robertson <williamrobertson13@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Jordan Gensler <jordan@mystenlabs.com>

hayes-mysten requested a review from a team as a code owner December 16, 2025 23:08

hayes-mysten temporarily deployed to sui-typescript-aws-kms-test-env December 16, 2025 23:09 — with GitHub Actions Inactive

vercel bot deployed to Preview December 16, 2025 23:11 View deployment

hayes-mysten force-pushed the mh--sdk-v2-suins branch from 14d0287 to 30876c4 Compare December 16, 2025 23:13

hayes-mysten temporarily deployed to sui-typescript-aws-kms-test-env December 16, 2025 23:13 — with GitHub Actions Inactive

vercel bot deployed to Preview December 16, 2025 23:14 View deployment

hayes-mysten force-pushed the mh--sdk-v2-suins branch from 30876c4 to 6402c63 Compare December 16, 2025 23:14

hayes-mysten temporarily deployed to sui-typescript-aws-kms-test-env December 16, 2025 23:14 — with GitHub Actions Inactive

vercel bot deployed to Preview December 16, 2025 23:16 View deployment

hayes-mysten force-pushed the mh--sdk-v2-suins branch from 6402c63 to 8692aa2 Compare December 16, 2025 23:28

hayes-mysten temporarily deployed to sui-typescript-aws-kms-test-env December 16, 2025 23:28 — with GitHub Actions Inactive

vercel bot deployed to Preview December 16, 2025 23:29 View deployment

hayes-mysten force-pushed the mh--sdk-v2-suins branch from 8692aa2 to f77e3f2 Compare December 16, 2025 23:31

hayes-mysten temporarily deployed to sui-typescript-aws-kms-test-env December 16, 2025 23:31 — with GitHub Actions Inactive

vercel bot deployed to Preview December 16, 2025 23:33 View deployment

hayes-mysten force-pushed the mh--sdk-v2-suins branch from f77e3f2 to 1b9ad34 Compare December 16, 2025 23:37

hayes-mysten temporarily deployed to sui-typescript-aws-kms-test-env December 16, 2025 23:37 — with GitHub Actions Inactive

vercel bot deployed to Preview December 16, 2025 23:38 View deployment

hayes-mysten force-pushed the mh--sdk-v2-suins branch from 1b9ad34 to c98cd57 Compare December 18, 2025 19:07

hayes-mysten had a problem deploying to sui-typescript-aws-kms-test-env December 18, 2025 19:07 — with GitHub Actions Failure

vercel bot deployed to Preview December 18, 2025 19:14 View deployment

hayes-mysten force-pushed the mh--sdk-v2-suins branch from c98cd57 to 19d1ac7 Compare January 6, 2026 17:46

hayes-mysten had a problem deploying to sui-typescript-aws-kms-test-env January 6, 2026 17:46 — with GitHub Actions Failure

vercel bot deployed to Preview January 6, 2026 17:49 View deployment

hayes-mysten force-pushed the mh--sdk-v2-suins branch from 19d1ac7 to 50b0d5a Compare January 6, 2026 17:57

hayes-mysten had a problem deploying to sui-typescript-aws-kms-test-env January 6, 2026 17:57 — with GitHub Actions Failure

vercel bot deployed to Preview January 6, 2026 18:01 View deployment

Migrate suins to sdk-v2

9d48f4a

hayes-mysten force-pushed the mh--sdk-v2-suins branch from 50b0d5a to 9d48f4a Compare January 6, 2026 18:10

hayes-mysten temporarily deployed to sui-typescript-aws-kms-test-env January 6, 2026 18:10 — with GitHub Actions Inactive

vercel bot deployed to Preview January 6, 2026 18:12 View deployment

williamrobertson13 approved these changes Jan 9, 2026

View reviewed changes

hayes-mysten merged commit 7af5651 into sdk-v2 Jan 9, 2026
7 of 8 checks passed

hayes-mysten deleted the mh--sdk-v2-suins branch January 9, 2026 00:28

hayes-mysten added a commit that referenced this pull request Jan 9, 2026

Migrate suins to sdk-v2 (#743)

48745fe

hayes-mysten added a commit that referenced this pull request Jan 15, 2026

Migrate suins to sdk-v2 (#743)

73097de

hayes-mysten added a commit that referenced this pull request Jan 23, 2026

Migrate suins to sdk-v2 (#743)

78ca3ce

hayes-mysten added a commit that referenced this pull request Jan 28, 2026

Migrate suins to sdk-v2 (#743)

806d8d5

hayes-mysten added a commit that referenced this pull request Jan 28, 2026

Migrate suins to sdk-v2 (#743)

2355e46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate suins to sdk-v2#743

Migrate suins to sdk-v2#743
hayes-mysten merged 1 commit intosdk-v2from
mh--sdk-v2-suins

hayes-mysten commented Dec 16, 2025 •

edited

Loading

Uh oh!

vercel bot commented Dec 16, 2025 •

edited

Loading

Uh oh!

williamrobertson13 left a comment •

edited

Loading

Uh oh!

williamrobertson13 Jan 9, 2026

Uh oh!

hayes-mysten Jan 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

hayes-mysten commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Test plan

AI Assistance Notice

Uh oh!

vercel bot commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

williamrobertson13 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

williamrobertson13 Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

hayes-mysten Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

hayes-mysten commented Dec 16, 2025 •

edited

Loading

vercel bot commented Dec 16, 2025 •

edited

Loading

williamrobertson13 left a comment •

edited

Loading