-
Notifications
You must be signed in to change notification settings - Fork 103
feat: implement blob streaming in the aggregator by slivers #2801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9a67517 to
a18a119
Compare
|
Warning: This PR modifies one of the example config files. Please consider the
|
3d6668f to
4de2dc4
Compare
fc5857a to
7ad8b46
Compare
7b33c91 to
2598d63
Compare
|
Removed myself since Markus is having a look. Let me know if there something that I should look at regardless. |
9529114 to
7b9ff3d
Compare
halfprice
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @wbbradley for implementing this feature! This looks great and I only have some minor comments.
Another thing we discussed was to use streaming blob as default and replace the existing blocking get_blob. Can you create a issue tracking this?
fc99dc3 to
83136c6
Compare
fe689cb to
ddd151c
Compare
|
@halfprice I believe I've addressed your comments. I've also implemented a new e2e test called |
|
I've added WAL-1107 to track using this functionality for |
halfprice
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks @wbbradley for adding this.
Description
Implement streaming blobs by slivers via a new endpoint
/v1/blobs/{blob_id}/stream.Test plan
Manually tested. CI Pipeline.
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that
a user might notice and any actions they must take to implement updates. (Add release notes after the colon for each item)
/v1alpha/blobs/{blob_id}/streamwhich is intended to reduce latency to first byte, and is intended to be used to stream blob data.