feat(bucket-object): add delete-marker flows [13/n]#3274
Open
sadhansood wants to merge 1 commit intosadhan/12-bucket-object-register-flowfrom
Open
feat(bucket-object): add delete-marker flows [13/n]#3274sadhansood wants to merge 1 commit intosadhan/12-bucket-object-register-flowfrom
sadhansood wants to merge 1 commit intosadhan/12-bucket-object-register-flowfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds delete-marker support to
bucket_object.The main changes are:
ObjectVersioncan now represent a blob-less delete marker vianew_delete_markerBucketObjectaddsdelete_objectanddelete_object_if_matchfinalize_pending_version_if_certifiednow promotes pending delete markers without requiring blob certificationput_object_if_absent_and_registernow treats a current delete marker as absent so keys can be recreated after deletionThis keeps the model consistent with the existing object-version flow: deletes are just another version transition, not a separate special-case object state.
Test plan
rustup run 1.86 cargo fmt -- --config group_imports=StdExternalCrate,imports_granularity=Crate,imports_layout=HorizontalVerticalcargo clippy --workspace --all-features --tests --no-deps -- -D warningssui move test --path /private/tmp/walrus-bucket-object-13/contracts/bucket_objectRelease notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that
a user might notice and any actions they must take to implement updates. (Add release notes after the colon for each item)