feat(bucket-object): add object metadata [15/n]#3276
Open
sadhansood wants to merge 1 commit intosadhan/14-bucket-object-headersfrom
Open
feat(bucket-object): add object metadata [15/n]#3276sadhansood wants to merge 1 commit intosadhan/14-bucket-object-headersfrom
sadhansood wants to merge 1 commit intosadhan/14-bucket-object-headersfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds first-class custom metadata to
bucket_object.The main changes are:
ObjectMetadatamodule backed byVecMap<String, String>ObjectVersionnow storesObjectMetadataThis keeps user metadata part of the immutable object-version snapshot, which gives us a stable base for later metadata-only update APIs, copy semantics, and gateway-facing
HeadObjectbehavior.Test plan
rustup run 1.86 cargo fmt -- --config group_imports=StdExternalCrate,imports_granularity=Crate,imports_layout=HorizontalVerticalcargo clippy --workspace --all-features --tests --no-deps -- -D warningssui move test --path /private/tmp/walrus-bucket-object-15/contracts/bucket_objectRelease notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that
a user might notice and any actions they must take to implement updates. (Add release notes after the colon for each item)