feat: auto install functionality

feat: improved settings registration methods that work with DI

Author: Tom Brewer

Mythetech.Framework.Desktop/Updates/VelopackUpdateService.cs

@@ -118,6 +118,13 @@ public async Task CheckForUpdatesAsync(CancellationToken cancellationToken = def
 
             await _messageBus.PublishAsync(new UpdateCheckCompleted(updateInfo));
             await _messageBus.PublishAsync(new UpdateAvailable(updateInfo));
+
+            var settings = _settingsProvider?.GetSettings<UpdateSettings>();
+            if (settings?.AutoDownload == true)
+            {
+                _logger.LogInformation("Auto-downloading update per settings");
+                await DownloadUpdateAsync(cancellationToken);
+            }
         }
         catch (Exception ex)
         {
@@ -163,7 +170,6 @@ public async Task DownloadUpdateAsync(CancellationToken cancellationToken = defa
 
             await manager.DownloadUpdatesAsync(veloUpdate, progress =>
             {
-                // Fire and forget progress updates - they're informational
                 _ = _messageBus.PublishAsync(new UpdateDownloadProgress(AvailableUpdate, progress));
             });
 

Mythetech.Framework.Test/Infrastructure/Settings/SettingsProviderTests.cs

@@ -1,6 +1,7 @@
 using Bunit;
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Logging;
+using Microsoft.Extensions.Options;
 using Mythetech.Framework.Infrastructure.MessageBus;
 using Mythetech.Framework.Infrastructure.Settings;
 using Mythetech.Framework.Infrastructure.Settings.Events;
@@ -23,7 +24,12 @@ public SettingsProviderTests()
             Array.Empty<IConsumerFilter>());
         Services.AddSingleton(_bus);
 
-        _provider = new SettingsProvider(_bus, Substitute.For<ILogger<SettingsProvider>>());
+        var options = Options.Create(new SettingsRegistrationOptions());
+        _provider = new SettingsProvider(
+            _bus,
+            Substitute.For<ILogger<SettingsProvider>>(),
+            Services.BuildServiceProvider(),
+            options);
     }
 
     [Fact(DisplayName = "Can register and retrieve settings by type")]

Mythetech.Framework/Infrastructure/Settings/SettingsProvider.cs

@@ -1,6 +1,8 @@
 using System.Reflection;
 using System.Text.Json;
+using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Logging;
+using Microsoft.Extensions.Options;
 using Mythetech.Framework.Infrastructure.MessageBus;
 using Mythetech.Framework.Infrastructure.Settings.Events;
 
@@ -21,10 +23,23 @@ public class SettingsProvider : ISettingsProvider
     /// </summary>
     /// <param name="bus">The message bus for publishing change events.</param>
     /// <param name="logger">Logger for diagnostics.</param>
-    public SettingsProvider(IMessageBus bus, ILogger<SettingsProvider> logger)
+    /// <param name="serviceProvider">Service provider for resolving settings instances.</param>
+    /// <param name="options">Options containing discovered settings types.</param>
+    public SettingsProvider(
+        IMessageBus bus,
+        ILogger<SettingsProvider> logger,
+        IServiceProvider serviceProvider,
+        IOptions<SettingsRegistrationOptions> options)
     {
         _bus = bus;
         _logger = logger;
+
+        // Auto-register settings that were discovered during service configuration
+        foreach (var type in options.Value.DiscoveredSettingsTypes)
+        {
+            var instance = (SettingsBase)serviceProvider.GetRequiredService(type);
+            RegisterSettings(instance);
+        }
     }
 
     /// <inheritdoc />

Mythetech.Framework/Infrastructure/Settings/SettingsRegistrationExtensions.cs

@@ -8,6 +8,17 @@
 
 namespace Mythetech.Framework.Infrastructure.Settings;
 
+/// <summary>
+/// Options for tracking settings types discovered during service configuration.
+/// </summary>
+public class SettingsRegistrationOptions
+{
+    /// <summary>
+    /// Types discovered via RegisterSettingsFromAssembly on IServiceCollection.
+    /// </summary>
+    public List<Type> DiscoveredSettingsTypes { get; } = new();
+}
+
 /// <summary>
 /// Extension methods for registering settings framework services.
 /// </summary>
@@ -125,13 +136,66 @@ public static IServiceCollection AddSettingsStorage(this IServiceCollection serv
         return services;
     }
 
+    /// <summary>
+    /// Scans an assembly for SettingsBase implementations, registers them as singletons,
+    /// and configures the SettingsProvider to auto-discover them.
+    /// This allows consumers to inject settings models directly.
+    /// </summary>
+    /// <param name="services">The service collection.</param>
+    /// <param name="assembly">The assembly to scan for settings types.</param>
+    /// <returns>The service collection for chaining.</returns>
+    public static IServiceCollection RegisterSettingsFromAssembly(
+        this IServiceCollection services,
+        Assembly assembly)
+    {
+        var settingsTypes = assembly.GetTypes()
+            .Where(t => !t.IsAbstract && typeof(SettingsBase).IsAssignableFrom(t))
+            .Where(t => t.GetConstructor(Type.EmptyTypes) != null);
+
+        foreach (var type in settingsTypes)
+        {
+            services.AddSingleton(type);
+        }
+
+        services.Configure<SettingsRegistrationOptions>(options =>
+        {
+            foreach (var type in settingsTypes)
+            {
+                if (!options.DiscoveredSettingsTypes.Contains(type))
+                    options.DiscoveredSettingsTypes.Add(type);
+            }
+        });
+
+        return services;
+    }
+
+    /// <summary>
+    /// Scans multiple assemblies for SettingsBase implementations, registers them as singletons,
+    /// and configures the SettingsProvider to auto-discover them.
+    /// This allows consumers to inject settings models directly.
+    /// </summary>
+    /// <param name="services">The service collection.</param>
+    /// <param name="assemblies">The assemblies to scan for settings types.</param>
+    /// <returns>The service collection for chaining.</returns>
+    public static IServiceCollection RegisterSettingsFromAssemblies(
+        this IServiceCollection services,
+        params Assembly[] assemblies)
+    {
+        foreach (var assembly in assemblies)
+        {
+            services.RegisterSettingsFromAssembly(assembly);
+        }
+        return services;
+    }
+
     /// <summary>
     /// Registers a settings model with the provider.
     /// Call after building the service provider.
     /// </summary>
     /// <typeparam name="T">The settings type to register.</typeparam>
     /// <param name="serviceProvider">The built service provider.</param>
     /// <returns>The service provider for chaining.</returns>
+    [Obsolete("Use IServiceCollection.RegisterSettingsFromAssembly() instead for DI-injectable settings.")]
     public static IServiceProvider RegisterSettings<T>(this IServiceProvider serviceProvider)
         where T : SettingsBase, new()
     {
@@ -147,6 +211,7 @@ public static IServiceProvider RegisterSettings<T>(this IServiceProvider service
     /// <param name="serviceProvider">The built service provider.</param>
     /// <param name="settings">The settings instance to register.</param>
     /// <returns>The service provider for chaining.</returns>
+    [Obsolete("Use IServiceCollection.RegisterSettingsFromAssembly() instead for DI-injectable settings.")]
     public static IServiceProvider RegisterSettings(this IServiceProvider serviceProvider, SettingsBase settings)
     {
         var provider = serviceProvider.GetRequiredService<ISettingsProvider>();
@@ -161,6 +226,7 @@ public static IServiceProvider RegisterSettings(this IServiceProvider servicePro
     /// <param name="serviceProvider">The built service provider.</param>
     /// <param name="assembly">The assembly to scan for settings types.</param>
     /// <returns>The service provider for chaining.</returns>
+    [Obsolete("Use IServiceCollection.RegisterSettingsFromAssembly() instead for DI-injectable settings.")]
     public static IServiceProvider RegisterSettingsFromAssembly(this IServiceProvider serviceProvider, Assembly assembly)
     {
         var provider = serviceProvider.GetRequiredService<ISettingsProvider>();
@@ -184,6 +250,7 @@ public static IServiceProvider RegisterSettingsFromAssembly(this IServiceProvide
     /// <param name="serviceProvider">The built service provider.</param>
     /// <param name="assemblies">The assemblies to scan for settings types.</param>
     /// <returns>The service provider for chaining.</returns>
+    [Obsolete("Use IServiceCollection.RegisterSettingsFromAssemblies() instead for DI-injectable settings.")]
     public static IServiceProvider RegisterSettingsFromAssemblies(
         this IServiceProvider serviceProvider,
         params Assembly[] assemblies)