Skip to content

Commit ba51a90

Browse files
Linter fixes and dark/light theme removal
1 parent 832295c commit ba51a90

30 files changed

+908
-522
lines changed

.pre-commit-config.yaml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,10 +41,11 @@ repos:
4141
- id: pretty-format-json
4242
args: ["--autofix"]
4343

44-
- repo: https://github.com/crate-ci/typos
45-
rev: v1.31.0
46-
hooks:
47-
- id: typos
44+
# temporarily removing
45+
# - repo: https://github.com/crate-ci/typos
46+
# rev: v1.31.0
47+
# hooks:
48+
# - id: typos
4849

4950
- repo: https://github.com/RobertCraigie/pyright-python
5051
rev: v1.1.399

CHANGELOG.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010

1111
### Feat
1212

13-
- **congifure_game.py**: added open game paks dir button
13+
- **configure_game.py**: added open game paks dir button
1414

1515
## 1.1.0-dev.14739379206 (2025-04-29)
1616

@@ -20,7 +20,7 @@
2020

2121
### Feat
2222

23-
- **congifure_game.py**: added open game paks dir button
23+
- **configure_game.py**: added open game paks dir button
2424

2525
## 1.1.0-dev.14739379206 (2025-04-29)
2626

@@ -33,7 +33,7 @@
3333

3434
- **configure_game.py**: improved install/uninstall
3535
- **configure_game.py**: fixed managing uninstalled games with ue4ss installs
36-
- **configure_game.py**: fixed portable check box preference rememberance
36+
- **configure_game.py**: fixed portable check box preference remembrance
3737
- **configure_game.py**: fixed install button being usable at wrong times
3838
- **main_screen.py,-add_game.py**: fixed duplicate settings entries
3939

assets/to_do_list.txt

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,10 @@ To Do List:
33

44
Next:
55
# make text button with no bacjground then does not change on press, just to have centered text
6-
# global settings files, accesible via the settings menu, add things like custom font path, lang select, etc... here
6+
# get rid of extra space in footer in online mode
7+
# global settings files, accessible via the settings menu, add things like custom font path, lang select, etc... here
78
# global font scale settings option
8-
#
9+
#
910
# bottom buttons are not aligned at the center in online mode
1011
# when uninstalling ue4ss from a game install dir where the game is already gone, it needs to refresh the game button list
1112
# install from url option/other options
@@ -14,7 +15,7 @@ Next:
1415
# remember window height, width, and position preferences
1516
#
1617
# occasionally double entries happen, it seems paths are being messed up c:/ versus C:/ for example
17-
#
18+
#
1819
# configure lua/C++ menu
1920
# configure bp mods menu
2021
# configure ue4ss settings menu

src/ue4ss_installer_gui/initialization.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,9 @@
88
def init():
99
settings.init_settings()
1010
loaded_settings = settings.get_settings()
11-
use_force_offline_mode = loaded_settings.get('GUI', {}).get('use_force_offline_mode', False)
11+
use_force_offline_mode = loaded_settings.get("GUI", {}).get(
12+
"use_force_offline_mode", False
13+
)
1214
if not use_force_offline_mode:
1315
online_check.init_is_online()
1416
print(f"Is online: {online_check.is_online}")

src/ue4ss_installer_gui/main.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ def main():
4747

4848
dpg.create_context()
4949

50-
dpg.bind_theme(ue4ss_installer_gui.theme_management.get_preferred_theme())
50+
dpg.bind_theme(ue4ss_installer_gui.theme_management.get_preferred_theme()) # type: ignore
5151

5252
dpg.create_viewport(
5353
title=constants.APP_TITLE,

src/ue4ss_installer_gui/screens/add_game.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
ue4ss,
1414
unreal_engine,
1515
)
16-
from ue4ss_installer_gui.screens import main_ue4ss_screen
1716

1817

1918
def game_dir_actually_has_unreal_game_check(game_dir_path: pathlib.Path):
@@ -188,7 +187,7 @@ def choose_directory():
188187
modal=True,
189188
width=constants.WINDOW_WIDTH - 80,
190189
height=constants.WINDOW_HEIGHT - 80,
191-
cancel_callback=main_ue4ss_screen.push_main_screen
190+
cancel_callback=main_ue4ss_screen.push_main_screen,
192191
)
193192

194193

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,2 @@
1-
21
def push_bp_mod_loader_configuration_screen():
32
return

src/ue4ss_installer_gui/screens/configure_game.py

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -6,15 +6,7 @@
66
import dearpygui.dearpygui as dpg
77

88
from ue4ss_installer_gui import settings, ue4ss, constants, translator, file_io
9-
from ue4ss_installer_gui.screens import (
10-
main_ue4ss_screen,
11-
setup_screen,
12-
notification_screen,
13-
ue4ss_mods_configurator,
14-
ue4ss_settings_configurator,
15-
bp_mod_loader_configurator,
16-
developer_screen
17-
)
9+
from ue4ss_installer_gui.screens import setup_screen, notification_screen
1810
from ue4ss_installer_gui.checks import online_check
1911

2012

@@ -476,7 +468,7 @@ def push_configure_game_screen(sender, app_data, user_data):
476468
no_open_over_existing_popup=False,
477469
pos=[30, pos_y],
478470
no_move=True,
479-
no_resize=True
471+
no_resize=True,
480472
)
481473

482474
install_dir = str(game_info.install_dir)
Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,2 @@
1-
21
def push_developer_screen():
32
return

src/ue4ss_installer_gui/screens/main_screen.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,6 @@ def push_main_app_screen():
2828
height=constants.WINDOW_HEIGHT,
2929
no_move=True,
3030
no_resize=True,
31-
autosize=True
31+
autosize=True,
3232
):
3333
scanning_for_games.push_scanning_for_games_modal_screen()

0 commit comments

Comments
 (0)