Fix glazed terracotta being 'upside down'#104
Open
Auseawesome wants to merge 1 commit intoN1nn1:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you look at glazed terracotta's blockstate definition in vanilla, it is rotated by 180 degrees compared to this mod's blockstates. I have rectified this with a single line change.
This is important because when making mods that interface with this mod, textures can seem to be upside down for reasons that are not immediately apparent (I discovered this when making my mod, Saturated Sands, compatible with this mod). It also is an issue for simple texture packs, if they have to invert the texture or edit the model where it otherwise would not have been needed.