Implementation for osAiGetStatus #75
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LittleCube-hax
force-pushed
the
osaigetstatus-impl
branch
from
cc4a6a3 to
6088c25
Compare
AngheloAlf
reviewed
Dec 29, 2024
| } | ||
|
|
||
| // Check if the most recently queued samples are playing, if not then consider the DMA as incomplete. | ||
| if (cur_frame_count > recent_frames_queued.load()) { |
Collaborator
There was a problem hiding this comment.
Shouldn't you be updating recent_frames_queued somewhere? Otherwise this will always eval to zero
Contributor
Author
There was a problem hiding this comment.
You're right, and upon further inspection adding the missing piece to this implementation breaks the recomp this was used for. It doesn't make sense to merge this if it's incomplete, so I'll close it for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.