Fix the issues of doctypes having 0 as a doctype #1031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ience Merging dev into this branch
Collaborator
|
Check the production database and confirm that no values for document type are anything except 1-5. If there is something that is not 1-5, we need to make a plan. Check the collections, and confirm that every single collection has a document type value of 1-5 Update that if statement, if doc has value display, else display collection value. If you want...you can do: if value not in documenttypes.choice, then raise valueerror, as well. |
dhanur-sharma
approved these changes
Feb 28, 2025
dhanur-sharma
deleted the
1030-resolve-0-value-document-type-in-nasa_science
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.