Updated template and job creation for scrapers and indexers#1072
Merged
bishwaspraveen merged 2 commits intodevfrom Feb 28, 2025
Merged
Conversation
This was
linked to
issues
Oct 15, 2024
CarsonDavis
reviewed
Oct 15, 2024
CarsonDavis
reviewed
Oct 15, 2024
CarsonDavis
reviewed
Oct 15, 2024
CarsonDavis
reviewed
Oct 15, 2024
CarsonDavis
reviewed
Nov 13, 2024
| <Url></Url> | ||
| <Plugin>SMD_Plugins/Sinequa.Plugin.WebCrawler_Index_URLList</Plugin> | ||
| <WorkerCount>6</WorkerCount> | ||
| <WorkerCount>8</WorkerCount> |
Collaborator
There was a problem hiding this comment.
Suggested change
| <WorkerCount>8</WorkerCount> | |
| <WorkerCount>4</WorkerCount> |
Collaborator
|
Wrt to the test_workflow_status_triggers test, Previously we interacted directly with GitHub but encountered authentication issues due to missing tokens. Now, GitHubHandler is mocked. If we want to interact with actual GitHub, the GitHub token should be stored as a secret in the repository settings (which requires admin permissions) and necessary changes must be made in the GitHub Actions workflow file. Additionally, to prevent unnecessary buildup, test cases should include steps to delete the config file post-verification, as config generation occurs with each test run. This can be done as part of Issue #3036. |
bishwaspraveen
deleted the
1052-update-cosmos-to-create-jobs-for-scrapers-and-indexers
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the templates to be used for scraper and indexer creation on workflow status change.
Updated the fields to be retained in the indexer when reading from the existing scraper.
Updated job creation into a single method for scrapers and indexers with the correct naming scheme.
Updated the nomenclature previously used for relevant methods.
Some test cases are written here which include the commits originally added to this branch.