Skip to content

Added https URL to allow CORS #1250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CarsonDavis merged 2 commits into from
Mar 18, 2025
Merged

Added https URL to allow CORS #1250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a22ade6
Added https URL to allow CORS
dhanur-sharma Mar 18, 2025
067af7a
Added changelog
dhanur-sharma Mar 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,3 +119,8 @@ For each PR made, an entry should be added to this changelog. It should contain
- Changes:
- Added a JavaScript validation check on form submission to ensure the document type (stored in a hidden input) is not empty.
- Display an error message and prevent form submission if the field is empty.

- 1249-add-https-link-to-cors_allowed_origins-for-sde-lrm
- Description: The feedback form API was throwing CORS errors and to rectify that, we need to add the apt https link for sde-lrm.
- Changes:
- Added `https://sde-lrm.nasa-impact.net` to `CORS_ALLOWED_ORIGINS` in the base settings.
1 change: 1 addition & 0 deletions config/settings/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@
CORS_ALLOWED_ORIGINS = [
"http://localhost:3000",
"http://sde-lrm.nasa-impact.net",
"https://sde-lrm.nasa-impact.net",
"https://sde-qa.nasa-impact.net",
"https://sciencediscoveryengine.test.nasa.gov",
"https://sciencediscoveryengine.nasa.gov",
Expand Down