Skip to content

Conversation

@BhattaraiSijan
Copy link
Collaborator

Purpose

  • Creates a document outlining the current implementation of Map engine and outlines the implementation plan for a map engine agnostic rendering for MMGIS

Issues

Copy link

@dzole0311 dzole0311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BhattaraiSijan I added one minor comment regarding the inline comments, but otherwise it looks like we're good to start moving forward on the implementation side

// Backward compatible reference
map: null,

// New engine abstraction

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BhattaraiSijan could we clean up inline comments like these? To me they feel a bit noisy and I'm not sure if they're adding much clarity.

We could also follow the approach we’ve used in VEDA, earth.gov and a few other projects, where we’ve generally kept a concise JSDoc comment at the top (describing the purpose of the component/utility/class) and only add inline comments when something isn’t obvious from the code itself. Maybe applying the same pattern here would make things a bit easier to scan and maintain?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants