Conversation
Tammo-Feldmann
left a comment
There was a problem hiding this comment.
@naomatheus I generally really like the idea of a pre-commit hook. I'm not convinced that we'd need to stand up a python virtual environment for this. I'd prefer to keep it all in javascript (although I have to admit that I don't have a very strong reason for this preference other than developer experience)
|
Hey @Tammo-Feldmann I was just seeing your comment on this. Totally makes sense. The other option is don't run to pre-commit on your local machine, but you'll see the linting messages from pre-commit as they're omitted from the |
|
@naomatheus I only just saw your comment on this. Thank you for your thoughts and for pushing back. It's always good for me to think this through a bit more. I'm not sure understand why you'd want to run a pre-commit hook manually. Isn't it there to catch those things that we forget to run manually? |
Whoops! Just opening this.
Summary:
Adds pre commit config and description and instructions