Skip to content

Conversation

@dzole0311
Copy link
Collaborator

@dzole0311 dzole0311 commented Aug 21, 2025

This PR updates the EnhancedMapBlock in next-veda-ui to align with recent veda-ui changes (#1808
). Instead of passing full datasets into MapBlock we now reconcile and prepare baseDataLayer (and optional compareDataLayer) before rendering.

  1. MapBlock receives only baseDataLayer and compareDataLayer props
  2. No direct passing of raw datasets in MapBlock / aligns the Next.js instance usage with the latest MapBlock changes in veda-ui
  3. Fix yarn.lock

Test instructions:

  1. Open any story with MapBlock and verify that they work as expected (example)

@netlify
Copy link

netlify bot commented Aug 21, 2025

Deploy Preview for veda-ui-next-test ready!

Name Link
🔨 Latest commit df7559d
🔍 Latest deploy log https://app.netlify.com/projects/veda-ui-next-test/deploys/68b6e6350a9d5f0008eedec7
😎 Deploy Preview https://deploy-preview-94--veda-ui-next-test.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@dzole0311 dzole0311 requested a review from vgeorge September 1, 2025 05:49
Copy link
Collaborator

@vgeorge vgeorge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dzole0311 this is functional, but I wonder if we can avoid disabling type checks. The motivation seems to be that the Veda UI library doesn’t export the type definitions used here, but I think we should copy them into this repo to stay on the type safe side. I know this could bring maintainability issues, but we can create a ticket upstream to increase the exported types coverage.

@dzole0311
Copy link
Collaborator Author

@vgeorge I think we can’t copy the full type set because some of the types use enums and TS is stricter with enums. If you declare the same enum in two places, TS won’t let you use one where the other is expected (eg. you would get an error like Type 'TimeDensity' is not assignable to type '_TimeDensity1').

I made a minimal local copy of the two needed types + linked a tracking issue and removed the ts-nocheck comments.

@dzole0311 dzole0311 requested a review from vgeorge September 2, 2025 13:07
Copy link
Collaborator

@vgeorge vgeorge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dzole0311 thanks for opening the upstream ticket. This looks good to merge 🙂

@dzole0311 dzole0311 merged commit 006ab9a into main Sep 3, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants