fix: Updates to fail gracefully if there are no assets to resolve key_error#293
Merged
fix: Updates to fail gracefully if there are no assets to resolve key_error#293
Conversation
botanical
changed the title
anayeaye
reviewed
Jan 29, 2025
| assets.pop("thumbnail") | ||
| # if thumbnail was only asset, delete assets | ||
| if not assets: | ||
| if not assets and (assets is not None): |
Contributor
There was a problem hiding this comment.
We need to update line 24 too, so that we can test if assets exists
assets = payload.get("assets", {}) should be assets = payload.get("assets", None)
EDIT
I think having an assets key at all is a problem for the existing pipeline because the pipeline and stac schemas have conflicting assets meanings--so this level of logic about other non-thumbnail assets seems unhelpful. @ividito @botanical should we just check if assets is in payload.keys() and then if it is payload.pop("assets")?
Contributor
There was a problem hiding this comment.
I agree that the current logic is awkward. I also think we should just pop the assets from the payload.
anayeaye
approved these changes
Feb 13, 2025
smohiudd
approved these changes
Feb 13, 2025
ividito
approved these changes
Feb 13, 2025
botanical
changed the title
1 task
botanical
temporarily deployed
to
development
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Summary of changes
Addresses VEDA-287: Resolve Key error in veda_dataset_pipeline
Changes
payload.pop("assets")PR Checklist