Skip to content

fix: update promotion workflow to output promotion status#299

Merged
smohiudd merged 9 commits intomainfrom
issue-270/update-production-workflow
Feb 18, 2025
Merged

fix: update promotion workflow to output promotion status#299
smohiudd merged 9 commits intomainfrom
issue-270/update-production-workflow

Conversation

@botanical
Copy link
Copy Markdown
Member

@botanical botanical commented Feb 14, 2025

What Changed

  • I updated the promotion workflow to output a status so we know if it succeeds or fails
  • I fixed the issue with the transfer setting in the payload (the payload is wrapped within the conf field)
  • I updated the pr.yml workflow to exit gracefully if no file changes are found to publish/promote

Testing

I tested the promote-collection.py script locally with python3 ./scripts/promote_collection.py ingestion-data/staging/dataset-config/test-sm2a-staging.json "production" but would like to see the promote.yml workflow run through github actions entirely

@botanical botanical requested a review from smohiudd as a code owner February 14, 2025 23:39
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 15, 2025

Workflow Status

Starting workflow... View action run

🕵️ No new files found. No files will be published to staging or promoted to production.


# If the workflow fails at any point, the PR comment will be updated

- name: Update PR comment if no new files
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this path restriction should be enough to prevent running the job when a PR doesn't involve ingestion data changes?

name: Publish collection to staging

on:
  pull_request:
    branches: ['main']
    paths:
      # Run the workflow only if files inside this path are updated
      - ingestion-data/staging/dataset-config/*

https://github.com/NASA-IMPACT/veda-data/blob/main/.github/workflows/pr.yml#L16

@smohiudd smohiudd merged commit 9876efc into main Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants