fix: update promotion workflow to output promotion status#299
Merged
Conversation
Workflow StatusStarting workflow... View action run 🕵️ No new files found. No files will be published to staging or promoted to production. |
anayeaye
reviewed
Feb 18, 2025
|
|
||
| # If the workflow fails at any point, the PR comment will be updated | ||
|
|
||
| - name: Update PR comment if no new files |
Contributor
There was a problem hiding this comment.
I think this path restriction should be enough to prevent running the job when a PR doesn't involve ingestion data changes?
name: Publish collection to staging
on:
pull_request:
branches: ['main']
paths:
# Run the workflow only if files inside this path are updated
- ingestion-data/staging/dataset-config/*
https://github.com/NASA-IMPACT/veda-data/blob/main/.github/workflows/pr.yml#L16
anayeaye
approved these changes
Feb 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
transfersetting in the payload (the payload is wrapped within theconffield)Testing
I tested the promote-collection.py script locally with
python3 ./scripts/promote_collection.py ingestion-data/staging/dataset-config/test-sm2a-staging.json "production"but would like to see the promote.yml workflow run through github actions entirely