fix: Have LayerInfoModal take in linkProps for pathAttributeName to get working for modern template instance#1436
Merged
sandrahoang686 merged 3 commits intomainfrom Feb 6, 2025
Conversation
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
hanbyul-here
reviewed
Feb 4, 2025
hanbyul-here
reviewed
Feb 4, 2025
dzole0311
approved these changes
Feb 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Ticket: #1282
Related PR: NASA-IMPACT/next-veda-ui#42
Description of Changes
Use
linkPropsfrom VedaUIProvider in LayerInfoModal to get working for modern instances.Notes & Questions About Changes
@teamimpact/veda-ui@5.12.1-1282.0@teamimpact/veda-ui@5.12.1-1282.2was published from these changes. Once this PR is merged, I will unpublish this version and close template PR.
Validation / Testing