Skip to content

fix: update cmr query key to cache bust on start and end date #1928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ifsimicoded merged 2 commits into from
Nov 24, 2025
Merged

fix: update cmr query key to cache bust on start and end date #1928

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f74249
update cmr query key to cache bust on start and end date
ifsimicoded Nov 22, 2025
67f796d
remove unused export
ifsimicoded Nov 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/scripts/components/exploration/analysis-data.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ export function formatCMRResponse(statResponse: CMRStatistics): TimeseriesData {
return cmrResponse;
}

export async function requestCMRTimeseriesData({
async function requestCMRTimeseriesData({
Copy link
Contributor Author

@ifsimicoded ifsimicoded Nov 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this function is not used elsewhere. if functions are exported solely for tests, I suggest we prefix with private_ or _ so we can add a eslint rule to prevent imports of these functions outside of tests.

Copy link
Collaborator

@dzole0311 dzole0311 Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup! I agree with removing the export. We generally rely on module scope (exported vs. non-exported) to signal privacy rather than using naming prefixes like private_.

I think if we ever need to reuse this logic elsewhere, we should extract it into a dedicated util file or custom hook at that point. But for now, keeping it non-exported here is perfect.

start,
end,
aoi,
Expand Down Expand Up @@ -236,7 +236,7 @@ export async function requestCMRTimeseriesData({
? datasetData.tileApiEndpoint.replace('WebMercatorQuad/tilejson.json', '')
: envApiCMREndpoint;
const statResponse = await queryClient.fetchQuery(
['analysis', datasetData.id, 'cmr', aoi],
['analysis', datasetData.id, 'cmr', aoi, start, end],
Copy link
Contributor Author

@ifsimicoded ifsimicoded Nov 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice we don't use the formattedParamString in the query key. This leads me to believe it's desired that not all params should cache bust this query. In that case, are there any additional params I should add?

datasetData.timeInterval?

Copy link
Collaborator

@dzole0311 dzole0311 Nov 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good question!

For this dataset, the only parameters that actually vary with user interaction are start, end and the aoi.

datasetData.timeInterval?

timeInterval is a bit different. It’s a fixed prop of the dataset (eg. 'P1M' for monthly data) and comes straight from the config. With the current UI and architecture, users never change it and the backend (I think) doesn’t treat it as a dynamic input. Because of that, we don't have to include it in the key here.

async ({ signal }) => {
const { data } = await axios.post(
`${cmrTitilerEndpoint}/timeseries/statistics/?${formattedParamString}`,
Expand Down
Loading