Conversation
mtobia-nasa
requested review from
crainen-nasa,
eholum-nasa,
esheetz-nasa,
ezemler-nasa,
msavchen-nasa,
ndunkelb-nasa and
zbashir-nasa
eholum-nasa
left a comment
eholum-nasa
left a comment
There was a problem hiding this comment.
Looks good! Some minor nits and question.
| # To launch the hardware robot, first deploy the UR tools to activate the dashboard client | ||
| # in its own long-lived shell. | ||
| ros2 launch chonkur_deploy ur_tools.launch.py | ||
| ros2 launch chonkur_deploy chonkur_comm.launch.py |
There was a problem hiding this comment.
Should this be run on controls or console?
There was a problem hiding this comment.
I think running hande tool comm would benefit from being on controls but everything else should run on console. I'm going to separate those too out in the launch file and readme then merge this today
| package="ur_robot_driver", | ||
| executable="robot_state_helper", | ||
| name="ur_robot_state_helper", | ||
| output="screen", |
There was a problem hiding this comment.
And for the rest of these,
| output="screen", | |
| output="both", |
| ], | ||
| ) | ||
|
|
||
| urscript_interface = Node( |
There was a problem hiding this comment.
Because I know nothing about hardware, do we interact with the script interface from the GUI?
| "tool_tcp_port", | ||
| default_value="54321", | ||
| description="Remote port that will be used for bridging the tool's serial device. " | ||
| "Only effective, if use_tool_communication is set to True.", |
There was a problem hiding this comment.
I don't think this is true? This may have been copied from somewhere, but it was probably wrong there too lol. Can just take out the second line, unless you know if this is the case.
eholum-nasa
left a comment
eholum-nasa
left a comment
There was a problem hiding this comment.
@mtobia-nasa I pushed a few little fixes, most importantly:
- No UR script node
- Noting to be sure to run comms on the controls PC
If that works for you let me know by pushing the button
3 participants
Adds submodule
drt_ur_guiandchonkur_deploylaunch filechonkur_comm.launch.pyto launch the GUI. Also updates readmes to the new launch file.