Support for the structured products in the registry#728
Support for the structured products in the registry#728al-niessner wants to merge 2 commits intostructuredfrom
Conversation
In order for the registry-api to use the structured field names, need to quit doing the property name conversions. Made it selectable via the properties file just because the transition from one to the other may take a while. This gives us the freedom to use the same API code for older or newer registry-apis.
|
|
|
||
| # signal if the database being used is "flat" or "structured" | ||
| # used an enum of strings, "flat" or "structured" for future new types | ||
| registry.field.name.architecture=structured No newline at end of file |
There was a problem hiding this comment.
This is how you want to change between flat and structured DB. I am not sure if the postman tests will pass unless you have jumped them to structured already.
|
|
||
| static public String jsonPropertyToOpenProperty(String jsonProperty) { | ||
| return jsonProperty.replace(".", "/"); | ||
| if (SearchUtil.fnArch == null || SearchUtil.fnArch.equalsIgnoreCase("flat")) return jsonProperty.replace(".", "/"); |
There was a problem hiding this comment.
I made the default (older registry-api applications.properties file) behave as flat. We will need to change the == to != and the || to && if you want the missing property condition to be structured instead.
|
Why is sonar stuff now hidden? Not very useful that it tells me there is one new problem then will not tell me what it is. Should I just start randomly guessing? |
|
@al-niessner I'm not sure what's being hidden? I can visit the URL https://sonarcloud.io/dashboard?id=NASA-PDS_registry-api&pullRequest=728 — and I don't have to log in |
|
My resolution of URL says 1 new problem. A box with red X that says failed.
No like to mor details. Nothing. I can send a screenshot.
…On Mon, Feb 2, 2026, 9:47 AM Sean Kelly ***@***.***> wrote:
*nutjob4life* left a comment (NASA-PDS/registry-api#728)
<#728 (comment)>
@al-niessner <https://github.com/al-niessner> I'm not sure what's being
hidden? I can visit the URL
https://sonarcloud.io/dashboard?id=NASA-PDS_registry-api&pullRequest=728
— and I don't have to log in
—
Reply to this email directly, view it on GitHub
<#728 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIUBIRUXFMIMUFV32NER4L4J6ETFAVCNFSM6AAAAACTWXW6GGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTQMZWG4ZTEMBXGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Hi @al-niessner , we don't want to merge that in |
|
Different browser. I can see it in this browser. Anyway, gonna have to live with it as it is an artifact of springboot. |
|
It is written to work in both by changing the java property. If the develop is the flat branch then just change java property to flat. When merged into structured branch, change it to structured. Maybe I do not understand your development idea. Are develop and structured always going to remain apart or will structured be merged into develop? Anyway, I will be in the meeting tomorrow so we can cover it then. |
|
I do not understand the build failure that registry-loader-test-init did not complete successfully. Did you want me to dig into the cause? I see you moved the merge into branch to structured already. Thanks. |
tloubrieu-jpl
changed the title
3 participants
🗒️ Summary
In order for the registry-api to use the structured field names, need to quit doing the property name conversions. Made it selectable via the properties file just because the transition from one to the other may take a while. This gives us the freedom to use the same API code for older or newer registry-apis.
⚙️ Test Data and/or Report
All postman tests pass.
♻️ Related Issues
Last step. Closes #632
🤓 Reviewer Checklist
Reviewers: Please verify the following before approving this pull request.
Security & Quality
Testing & Validation
Documentation
Maintenance