Skip to content

Conversation

@al-niessner
Copy link
Contributor

@al-niessner al-niessner commented Jan 8, 2026

🗒️ Summary

After updating jparser to new snapshot, need to update this POM and make sure all of the unit tests run.

⚙️ Test Data and/or Report

All automate unit/regression tests complete successfully.

♻️ Related Issues

Closes #1241

🤓 Reviewer Checklist

Reviewers: Please verify the following before approving this pull request.

Security & Quality

  • SonarCloud: Confirmed no new High or Critical security findings.
  • Secrets Detection: Verified that the Secrets Detection scan passed and no sensitive information (keys, tokens, PII) is exposed.
  • Code Quality: Code follows organization style guidelines and best practices for the specific language (e.g., PEP 8, Google Java Style).

Testing & Validation

  • Test Accuracy: Verified that test data is accurate, representative of real-world PDS4 scenarios, and sufficient for the logic being tested.
  • Coverage: Automated tests cover new logic and edge cases.
  • Local Verification: (If applicable) Successfully built and ran the changes in a local or staging environment.

Documentation

  • Documentation: README, Wiki, or inline documentation (Sphinx, Javadoc, Docstrings) have been updated to reflect these changes.

Maintenance

  • Issue Traceability: The PR is linked to a valid GitHub Issue or Jira Ticket.
  • Backward Compatibility: Confirmed that these changes do not break existing downstream dependencies or API contracts (or that breaking changes are clearly documented).

The eclipse environment is overly sensitive to multiple resolutions of a package while maven seems more immune because of how it builds its resolution tree. Had to exclude part of jparser because Java 17 includes the xml-apis and so should not be imported from jparser as well.
@al-niessner al-niessner self-assigned this Jan 8, 2026
@al-niessner al-niessner requested a review from a team as a code owner January 8, 2026 19:07
@al-niessner al-niessner marked this pull request as draft January 8, 2026 19:07
@al-niessner al-niessner changed the title exclude unwanted java.xml resolutions 1241: patch to jparser for moving local files instead of using them Jan 8, 2026
@al-niessner
Copy link
Contributor Author

al-niessner commented Jan 8, 2026

@jordanpadams @tloubrieu-jpl

Please build and release this snapshot. Once done let me know and I will update the validate stuff to make sure that those tests complete successfully as well.

Never mind. Wrong PR.

@jordanpadams
Copy link
Member

@al-niessner the jparser update has been merged

@al-niessner
Copy link
Contributor Author

al-niessner commented Jan 12, 2026

@jordanpadams @nutjob4life

Okay, the testing is stable again. All the changes are really about that. Added more XSD and SCH to repo because JAXA fell offline again. Had the tests turned off in maven by accident. Turned them back on and moved the doubling switch - really the switch to turn off doubling all tests - to my eclipse configuration.

@jordanpadams if you give this a thumbs up review, then I will merge it. I will then fix the the updates as well.

@al-niessner al-niessner marked this pull request as ready for review January 12, 2026 21:34
@al-niessner al-niessner reopened this Jan 12, 2026
@jordanpadams jordanpadams changed the title 1241: patch to jparser for moving local files instead of using them Patch to jparser to use local file instead of attempting to download URL Jan 12, 2026
@jordanpadams jordanpadams merged commit 8737c1c into main Jan 12, 2026
4 checks passed
@jordanpadams jordanpadams deleted the issue_1241 branch January 12, 2026 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Validating large data file (150GB) is trying to write the entire file to local temp space - error upon not enough local space

3 participants