Fixed MSF calculation issue #144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… file, just print a warning and continue
… pstd array order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if the pstd dimension values are not in decreasing order (e.g., bottom to top of atmosphere), then the MSF calculation gets wonky. MarsInterp ensures the pstd dimension is decreasing, but if pressure interpolation is done outside CAP (e.g., with runpinterp.csh released with the NASA Ames Mars GCM) and the pstd dimension values are in increasing order, the MSF calculation is wrong. This bug fix checks the pstd order in mass_stream, calculates MSF properly, then puts the pstd back in the order it started with. In other words, this fix preserves the original order of values in pstd, only reversing it for the math.