-
Notifications
You must be signed in to change notification settings - Fork 8
Includes area-weighted global average upon -stat; fixes some pressure interp issues #155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s created by prop_tides and tide_decomp
…s created by prop_tides and tide_decomp
…tomatically, I want ps in the final file. moving to MarsFiles
… for compatibility with pinterp
…ributes from the original file
…sues. the real fix here is to refactor all of CAP into xarray
…sues. the real fix here is to refactor all of CAP into xarray
…sues. the real fix here is to refactor all of CAP into xarray
…sues. the real fix here is to refactor all of CAP into xarray
…sues. the real fix here is to refactor all of CAP into xarray
…sues. the real fix here is to refactor all of CAP into xarray
… convert a scalar to an int
…hted mean before printing
Collaborator
|
The MarsFormat failed tests seem to be caused by existing code unrelated to this PR. I am inclined to approve the PR if we can make sure that the actual changes pass the tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopening PR this way since changes aren't appearing to take effect in the nasa branch
MarsPlot -i filename -stat varnamenow returns area-weighted global means for non-time variablesIn netcdf files CAP creates, I've made sure that ps is always added to the new file so it can be interpolated later if desired.
In netcdf files CAP creates, I've made sure to indicate that pfull is positive=down