Draft
Conversation
…meseries. The idea here is: 1. Hard-code model_component="lnd" everywhere it's needed in global_mean_timeseries_lnd to handle land-specific behaviors 2. Add handling for model_component!="lnd" in global_mean_timeseries_lnd to handle behaviors only in global_mean_timeseries. 3. Paste the contents of global_mean_timeseries_lnd into global_mean_timeseries, deleting the former. 4. Add model_component inputs to all functions there as needed. 5. Optimize, including by deleting repeated code.
samsrabin
added
code clean-up
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The clm-diags branch currently has two very similar scripts:
scripts/plotting/global_mean_timeseries.pyandscripts/plotting/global_mean_timeseries_lnd.py. This PR will combine them (and a related pair of functions) to reduce duplicated code.My plan here:
spatial_average_lndfunction intospatial_average.model_component = "lnd"everywhere it's needed inglobal_mean_timeseries_lndto handle land-specific behaviorsmodel_component != "lnd"inglobal_mean_timeseries_lndto handle behaviors only in global_mean_timeseries.global_mean_timeseries_lndintoglobal_mean_timeseries, deleting the former.model_componentinput args to all functions there as needed.As of b144327, I'm nearing the end of step 2.