Skip to content

Support multiple phases for modal model#118

Merged
boulderdaze merged 2 commits intomainfrom
support_multiple_phases
Jul 17, 2025
Merged

Support multiple phases for modal model#118
boulderdaze merged 2 commits intomainfrom
support_multiple_phases

Conversation

@boulderdaze
Copy link
Contributor

@boulderdaze boulderdaze commented Jul 14, 2025

This PR

Current:

{
  "name": "accumulation",
  "geometric mean diameter [m]": 1.1e-7,
  "geometric standard deviation": 1.8,
  "phase": "aqueous"
}

Updated:

{
  "name": "accumulation",
  "geometric mean diameter [m]": 1.1e-7,
  "geometric standard deviation": 1.8,
  "phase": ["aqueous", "organic"]
}

@boulderdaze boulderdaze self-assigned this Jul 14, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.95%. Comparing base (149c200) to head (2a07d1d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #118   +/-   ##
=======================================
  Coverage   86.95%   86.95%           
=======================================
  Files           3        3           
  Lines          23       23           
=======================================
  Hits           20       20           
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@boulderdaze boulderdaze marked this pull request as ready for review July 14, 2025 21:39
@boulderdaze boulderdaze requested a review from K20shores July 14, 2025 21:45
@boulderdaze boulderdaze merged commit a3647c4 into main Jul 17, 2025
15 checks passed
@boulderdaze boulderdaze deleted the support_multiple_phases branch July 17, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support multiple phases per mode in modal model type

3 participants