Skip to content

Add complete dask compatibility testing#819

Merged
anissa111 merged 22 commits intoNCAR:mainfrom
anissa111:daskcompat
Feb 18, 2026
Merged

Add complete dask compatibility testing#819
anissa111 merged 22 commits intoNCAR:mainfrom
anissa111:daskcompat

Conversation

@anissa111
Copy link
Member

PR Summary

  • Expands tests/test_dask.py to test all functions under geocat-comp (except name aliases, internal functions, and functions that just wrap other geocat-comp functions)
    • notes if existing functions are not currently compatible by having a test, but marking it as an expected failure
  • Adds a conftest.py to handle some pytest fixtures so they can be used in multiple test files, reconfigures some existing fixtures to live in conftest.py
  • makes small changes to relhum_water and relhum_ice to make them dask compatible
  • reformats a couple places where black was forcing 1 item/line lists that were really annoying

Related Tickets & Documents

Closes https://github.com/NCAR/geocat-planning/issues/27

PR Checklist

General

  • PR includes a summary of changes
  • Link relevant issues, make one if none exist
  • Add a brief summary of changes to docs/release-notes.rst in a relevant section for the upcoming release.
  • Add appropriate labels to this PR
  • PR follows the Contributor's Guide

@anissa111 anissa111 added testing Issue related to testing scalability and performance Related to scalability, performance, or benchmarking labels Feb 17, 2026
Copy link
Collaborator

@kafitzgerald kafitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

Will be nice to have this all documented (i.e. the xfails) and easily testable.

I'd forgotten (or maybe just didn't know) how many things weren't compatible.

@anissa111 anissa111 merged commit d8c3346 into NCAR:main Feb 18, 2026
17 checks passed
@anissa111 anissa111 deleted the daskcompat branch February 18, 2026 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scalability and performance Related to scalability, performance, or benchmarking testing Issue related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments