Fix dimension mismatch in Rosenbrock solver when constraints are present#929
Closed
Copilot wants to merge 3 commits intov2-review-dae-3-rosenbrock-integrationfrom
Closed
Fix dimension mismatch in Rosenbrock solver when constraints are present#929Copilot wants to merge 3 commits intov2-review-dae-3-rosenbrock-integrationfrom
Copilot wants to merge 3 commits intov2-review-dae-3-rosenbrock-integrationfrom
Conversation
Co-authored-by: boulderdaze <55209567+boulderdaze@users.noreply.github.com>
Co-authored-by: boulderdaze <55209567+boulderdaze@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] WIP Address feedback on V2 review dae 3 integration
Fix dimension mismatch in Rosenbrock solver when constraints are present
Feb 11, 2026
boulderdaze
approved these changes
Feb 11, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v2-review-dae-3-rosenbrock-integration #929 +/- ##
==========================================================================
+ Coverage 94.66% 94.69% +0.03%
==========================================================================
Files 68 68
Lines 3485 3241 -244
==========================================================================
- Hits 3299 3069 -230
+ Misses 186 172 -14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
K20shores
reviewed
Feb 11, 2026
| } | ||
|
|
||
| Ynew.Copy(Y); | ||
| // Copy only species variables from Y to Ynew. |
Collaborator
There was a problem hiding this comment.
I think the actual problem is that the temporary variables for the class are not properly sized. There is no reason Ynew and Y should ever have different sizes
Collaborator
|
Closing, superceded by #931 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When DAE constraints are enabled,
variables_has dimensionstate_size_(species only) while temporary matrices (Ynew,K[], etc.) have dimensionstate_size_ + constraint_size_. Line 150 calledYnew.Copy(Y)which throws a runtime error on dimension mismatch.Changes
Ynew.Copy(Y)at line 150 with manual element-wise copy of species variables onlyYnew.NumRows()instead ofY.NumRows()in both copy loops for consistency with destination arrayThis mirrors the existing pattern at line 105-116 which already handled this correctly.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.