Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the ChemicalReactionBuilder::SetAerosolScope API (and associated scoping logic) along with its unit tests, based on it having no remaining usage since the ExternalModel abstraction was introduced.
Changes:
- Removed
SetAerosolScopefromChemicalReactionBuilderand deleted all related scoping/state-tracking logic. - Deleted the
process_configurationunit test file that validated aerosol scoping behavior and removed the test target from CMake.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
include/micm/process/chemical_reaction_builder.hpp |
Removes the SetAerosolScope public API and related internal scoping logic. |
test/unit/process/test_process_configuration.cpp |
Deletes the unit tests that covered the removed aerosol scoping behavior. |
test/unit/process/CMakeLists.txt |
Removes the process_configuration test target so the deleted test file is no longer built. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #947 +/- ##
==========================================
- Coverage 94.28% 94.04% -0.24%
==========================================
Files 69 68 -1
Lines 3833 3797 -36
==========================================
- Hits 3614 3571 -43
- Misses 219 226 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
K20shores
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since introducing
ExternalModelabstraction, the following functions have no usage.Deletes
SetAerosolScope(),JoinStrings(...)