Skip to content

Conversation

@scrasmussen
Copy link
Member

@scrasmussen scrasmussen commented Apr 3, 2025

TYPE: fix

KEYWORDS: Training, Croton, CIeanup

SOURCE: Soren Rasmussen, NSF NCAR

REQUIRES: NCAR/wrf_hydro_docker#156 PR needs to be pushed to Dockerhub first for this one to work

DESCRIPTION OF CHANGES:

  • Training updated and working, supplemental still broken from packages they use
  • New bash script run_training_notebooks.sh to build all non-supplemental trainings
    • this builds all notebooks and should be done before committing notebook changes so the formatting is the same
    • used for CI
  • Github CI has cron job to run every Monday morning
  • Pull Request Template Added

NOTE: line 381 of the original lessons/training/Lesson-7-configurations.ipynb had gage ID's that I couldn't match up so the one's I chose probably don't make sense?

TESTS CONDUCTED: Built and ran uncoupled trainings.

List of changes
 - Training updated and working, supplemental still broken from packages they use
 - Github CI added to run run_training_notebooks.sh, which builds all non-supplemental trainings
 - Github CI has cron job to run every Monday morning
 - Pull Request Template Added
@scrasmussen scrasmussen force-pushed the enhancement/v5.4.0-updates branch from d4ad441 to 6a49378 Compare April 4, 2025 16:16
@scrasmussen scrasmussen force-pushed the enhancement/v5.4.0-updates branch from e0e0e2c to 6f21eb1 Compare May 13, 2025 23:51
@scrasmussen scrasmussen force-pushed the enhancement/v5.4.0-updates branch from 6f21eb1 to fe43dd9 Compare May 14, 2025 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant