Skip to content

Conversation

@valeriupredoi
Copy link
Collaborator

Description

Related to #231

I linted all the code in the main source activestorage/ and added a flake8 test at push.
@davidhassell I'd like a review on this one please, when you have a minute (ie am not gonna barge-merge it like other PRs that were purely functional), the linting is via black, but am not popping black in just yet, I think I'll let flake8 detect any incoming issues for now. What do you think?

Before you get started

Checklist

  • This pull request has a descriptive title and labels
  • This pull request has a minimal description (most was discussed in the issue, but a two-liner description is still desirable)
  • Unit tests have been added (if codecov test fails)
  • Any changed dependencies have been added or removed correctly (if need be)
  • If you are working on the documentation, please ensure the current build passes
  • All tests pass

@valeriupredoi valeriupredoi added the enhancement New feature or request label Jul 16, 2025
@codecov
Copy link

codecov bot commented Jul 16, 2025

Codecov Report

❌ Patch coverage is 88.18182% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.98%. Comparing base (133537d) to head (4c3e3fd).
⚠️ Report is 39 commits behind head on main.

Files with missing lines Patch % Lines
activestorage/active.py 77.77% 10 Missing ⚠️
activestorage/dummy_data.py 97.22% 1 Missing ⚠️
activestorage/hdf2numcodec.py 66.66% 1 Missing ⚠️
activestorage/reductionist.py 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #281      +/-   ##
==========================================
+ Coverage   85.20%   85.98%   +0.77%     
==========================================
  Files           7        7              
  Lines         649      642       -7     
==========================================
- Hits          553      552       -1     
+ Misses         96       90       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@valeriupredoi
Copy link
Collaborator Author

Ive decided to skip black -ing the code, too specific a formatter for now, so will just pylint with yapf instead, minimal approach 🤏

@valeriupredoi
Copy link
Collaborator Author

valeriupredoi commented Jul 17, 2025

cov variation is OK - we're covered by "slow" tests that are skipped - the actual absolute coverage increases by 0.8%
@davidhassell the actual code looks pretty good, am gonna merge 🍻

@valeriupredoi valeriupredoi merged commit e74d0ce into main Jul 17, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants