-
Notifications
You must be signed in to change notification settings - Fork 2
Lint code in activestorage/ and add flake8 test at push
#281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #281 +/- ##
==========================================
+ Coverage 85.20% 85.98% +0.77%
==========================================
Files 7 7
Lines 649 642 -7
==========================================
- Hits 553 552 -1
+ Misses 96 90 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Ive decided to skip black -ing the code, too specific a formatter for now, so will just pylint with yapf instead, minimal approach 🤏 |
|
cov variation is OK - we're covered by "slow" tests that are skipped - the actual absolute coverage increases by 0.8% |
Description
Related to #231
I linted all the code in the main source
activestorage/and added a flake8 test at push.@davidhassell I'd like a review on this one please, when you have a minute (ie am not gonna barge-merge it like other PRs that were purely functional), the linting is via black, but am not popping black in just yet, I think I'll let flake8 detect any incoming issues for now. What do you think?
Before you get started
Checklist