Skip to content

Conversation

@valeriupredoi
Copy link
Collaborator

@valeriupredoi valeriupredoi commented Jul 17, 2025

Description

@bnlawrence these are old stale directories that should be removed, please holler back if you still need any of the stiff there 🍺

Related to #231

Before you get started

Checklist

  • This pull request has a descriptive title and labels
  • This pull request has a minimal description (most was discussed in the issue, but a two-liner description is still desirable)
  • Unit tests have been added (if codecov test fails)
  • Any changed dependencies have been added or removed correctly (if need be)
  • If you are working on the documentation, please ensure the current build passes
  • All tests pass

@valeriupredoi valeriupredoi added the package specific issues about deploying testing packaging etc label Jul 17, 2025
@codecov
Copy link

codecov bot commented Jul 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.00%. Comparing base (8c8aa26) to head (f9f4632).
⚠️ Report is 19 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #283   +/-   ##
=======================================
  Coverage   86.00%   86.00%           
=======================================
  Files           7        7           
  Lines         643      643           
=======================================
  Hits          553      553           
  Misses         90       90           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@bnlawrence bnlawrence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. Thanks.

@valeriupredoi
Copy link
Collaborator Author

All good. Thanks.

cheers, Bryan 🍻

@valeriupredoi valeriupredoi merged commit f448bf1 into main Jul 17, 2025
4 checks passed
@valeriupredoi valeriupredoi deleted the remove_bnl_old_code branch July 17, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package specific issues about deploying testing packaging etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants