Fix to broken link to PDF cheatsheet #831
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick PR to fix a link to the PDF cheat sheet which is broken since the hash in the link wasn't removed somehow in the build process: see https://ncas-cms.github.io/cf-python/cheat_sheet.html and try to click 'pdf' (or open it in a new tab, remove the hash component and it works). I want to update this manually in the built HTML since I want to update the Intro. Scientific Computing to include a link to the cheat sheet from the current docs and don't want a broken link sitting there for someone to find.
I would have just pushed this fix as a lone commit if it weren't for the fact that I wanted to check if we need to update the release script in case anything is wrong that led to the hash component not getting removed to break the link, but actually taking a quick look the logic looks fine to me, so I am at a loss as to why the hash remained there in the latest release process:
cf-python/release_docs
Lines 91 to 101 in 0c5af83
Any ideas @davidhassell? If not I'll assume we did something wrong in the last release build and we can just merge this fix as-is.