Skip to content

Improve detection of cyclic axes #852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 11, 2025
Merged

Improve detection of cyclic axes #852

merged 3 commits into from
Mar 11, 2025

Conversation

davidhassell
Copy link
Collaborator

Fixes #851

Hopefully self explanatory (!).

Notes:

  • cf.Field.iscyclic has been deleted, as it was a needless duplication of cf.mixin.fielddomain.iscyclic
  • the "dry_run" stuff is really what all those "if noop"s should ahve been :)

@davidhassell davidhassell added the enhancement New feature or request label Mar 7, 2025
@davidhassell davidhassell added this to the NEXT VERSION milestone Mar 7, 2025
sadielbartholomew
sadielbartholomew approved these changes Mar 10, 2025
View reviewed changes
Copy link
Member

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Please merge.

@davidhassell davidhassell merged commit f2e0d41 into NCAS-CMS:main Mar 11, 2025
2 of 4 checks passed
@davidhassell davidhassell deleted the cyclic branch March 11, 2025 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadielbartholomew sadielbartholomew sadielbartholomew approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
3.17.0
Development

Successfully merging this pull request may close these issues.

Improve detection of cyclic axes
2 participants
@davidhassell @sadielbartholomew