Skip to content

Add distributed as required dependency with version pin #880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 24, 2025
Merged

Add distributed as required dependency with version pin #880

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
98a3009
Add distributed pin on v.2025.5.1 to requirements
sadielbartholomew Jul 21, 2025
f725803
Add check for suitable importable distributed module
sadielbartholomew Jul 21, 2025
377a476
Lint to apply line wrapping (one character over limit)
sadielbartholomew Jul 21, 2025
5d87878
Update cf.environment example for new addition, distributed
sadielbartholomew Jul 21, 2025
bf04c40
Docs: add distrbiuted to installation page requires list
sadielbartholomew Jul 21, 2025
6ee5d52
Docs: clarify validity of newer vers of dask & distributed
sadielbartholomew Jul 21, 2025
9993f68
Update changelog for new dependency
sadielbartholomew Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Changelog.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ Version NEXTVERSION
* New methods to allow changing units in a chain: `cf.Field.to_units`,
`cf.Data.to_units`
(https://github.com/NCAS-CMS/cf-python/issues/874)
* New dependency: ``distributed>=2025.5.1``

----

Expand Down
13 changes: 13 additions & 0 deletions cf/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,19 @@
f"Got {dask.__version__} at {dask.__file__}"
)

try:
import distributed
except ImportError as error1:
raise ImportError(_error0 + str(error1))
else:
_minimum_vn = "2025.5.1"
if Version(distributed.__version__) < Version(_minimum_vn):
raise ValueError(
"Bad distributed version: cf requires "
f"distributed>={_minimum_vn}. "
f"Got {distributed.__version__} at {distributed.__file__}"
)

try:
import scipy
except ImportError as error1:
Expand Down
2 changes: 2 additions & 0 deletions cf/functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3171,6 +3171,7 @@ def environment(display=True, paths=True):
s3fs: 2024.12.0 /home/miniconda3/lib/python3.12/site-packages/s3fs/__init__.py
scipy: 1.15.1 /home/miniconda3/lib/python3.12/site-packages/scipy/__init__.py
dask: 2025.5.1 /home/miniconda3/lib/python3.12/site-packages/dask/__init__.py
distributed: 2025.5.1 /home/miniconda3/lib/python3.12/site-packages/distributed/__init__.py
cftime: 1.6.4.post1 /home/miniconda3/lib/python3.12/site-packages/cftime/__init__.py
cfunits: 3.3.7 /home/miniconda3/lib/python3.12/site-packages/cfunits/__init__.py
cfdm: 1.12.2.0 /home/miniconda3/lib/python3.12/site-packages/cfdm/__init__.py
Expand All @@ -3196,6 +3197,7 @@ def environment(display=True, paths=True):
s3fs: 2024.12.0
scipy: 1.15.1
dask: 2025.5.1
distributed: 2025.5.1
cftime: 1.6.4.post1
cfunits: 3.3.7
cfdm: 1.12.2.0
Expand Down
5 changes: 4 additions & 1 deletion docs/source/installation.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,10 @@ Required

* `numpy <http://www.numpy.org>`_, versions 2.0.0 or newer.

* `dask <https://pypi.org/project/dask>`_, version 2025.5.1.
* `dask <https://pypi.org/project/dask>`_, version 2025.5.1 or newer.

* `distributed <https://pypi.org/project/distributed>`_, version 2025.5.1 or
newer.

* `netCDF4 <https://pypi.org/project/netcdf4/>`_, 1.7.2 or newer.

Expand Down
1 change: 1 addition & 0 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,6 @@ cfdm>=1.12.2.0, <1.12.3.0
psutil>=0.6.0
cfunits>=3.3.7
dask>=2025.5.1
distributed>=2025.5.1
packaging>=20.0
scipy>=1.10.0
Loading