Skip to content

cf.Field.collapse fails when cell measure has external data #886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 7, 2025
Merged

cf.Field.collapse fails when cell measure has external data #886

merged 5 commits into from
Aug 7, 2025

Conversation

davidhassell
Copy link
Collaborator

@davidhassell davidhassell commented Aug 7, 2025 •
edited
Loading

Fixes #885

Essentially adds a auto=True that should have been there for ever; improves (I think :)) the cf.Field.collapse docstring for the weights keyword; and livens up some error messages in Weights.cell_measure.

@davidhassell davidhassell added this to the NEXTVERSION milestone Aug 7, 2025
@davidhassell davidhassell added the bug Something isn't working label Aug 7, 2025
sadielbartholomew
sadielbartholomew approved these changes Aug 7, 2025
View reviewed changes
Copy link
Member

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good bar a few very minor comments (and that I can see this would be difficult to test given the need for a external file to contain the cell measures so I'll excuse no new test to cover the issue 🙂). Please merge when ready,

davidhassell and others added 2 commits August 7, 2025 17:41
@davidhassell @sadielbartholomew
Typos
56f2684 
Co-authored-by: Sadie L. Bartholomew <[email protected]>
@davidhassell @sadielbartholomew
Update Changelog.rst
96c0f17 
Co-authored-by: Sadie L. Bartholomew <[email protected]>
@davidhassell davidhassell merged commit 6ac5ae0 into NCAS-CMS:main Aug 7, 2025
@davidhassell davidhassell deleted the collapse-cell-measures branch August 7, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadielbartholomew sadielbartholomew sadielbartholomew approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
NEXTVERSION
Development

Successfully merging this pull request may close these issues.

cf.Field.collapse fails when cell measure has external data
2 participants
@davidhassell @sadielbartholomew