Skip to content

cf.Data.arctan2(): Fixes NCAS-CMS/cf-python#890 by trying to conform valid units first. #891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 27, 2025
Merged

cf.Data.arctan2(): Fixes NCAS-CMS/cf-python#890 by trying to conform valid units first. #891

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c7b9128
Fixes NCAS-CMS/cf-python#890 by trying to conform valid units first.
ThatDesert Aug 15, 2025
fd3a8a3
Improve clarity in function description.
ThatDesert Aug 27, 2025
05dc56f
Drop type check
ThatDesert Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion cf/data/data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4407,7 +4407,9 @@ def arctan2(cls, x1, x2):
x2: array_like
X coordinates. *x1* and *x2* must be broadcastable to
a common shape (which becomes the shape of the
output).
output). If both *x1* and *x2* have units, they must
be equal or equivalent, in which case they
will be conformed.

:Returns:

Expand All @@ -4434,6 +4436,9 @@ def arctan2(cls, x1, x2):
[90.0 -90.0]

"""

x1 = conform_units(x1, x2.Units)

try:
y = x1.to_dask_array()
except AttributeError:
Expand Down