-
Notifications
You must be signed in to change notification settings - Fork 1
correct Python pinning in environment.yml and pyproject.toml #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Huh? Is cf-python not supporting 3.10 any more? |
Nope, for a while now - two years? @davidhassell |
|
I thought the done thing was to support versions for as long as they were live, which should be five years, which means I guess we could lose this in October, so being 9 months early is not the end of the world, so ok, here, now, but we need to have a chat about the principle. |
|
I am but the messenger here, Bryan - we need to pin it here, otherwise a Python 3.10 env will fail solving with libmamba moaning it can't solve for cf-python. Having said that, I remember David had some good reasons why drop 3.10, alas, iris has too 😁 |
|
cf-python does indeed support Python 3.10, and I expect it to for some time yet. It only stopped supporting 3.9 when it was EoL, in October 2025 |
Well then you have to change your conda recipe and build for and with 3.10 - but I have a hunch that won't work https://github.com/conda-forge/cf-python-feedstock/blob/main/recipe/meta.yaml |
|
@davidhassell the last At any rate, if you want to use Numpy 2.3 or newer, you ought to drop support for Python 3.10 anyway - so I reckon you did well back in April last year (sorry, not two years haha) when you dropped Python 3.10 🍺 |
What are you basing this statement on? It's incorrect, since I can install (as just tested) the latest (just released last week) cf-python, 3.19.0, on a Python 3.10 conda environment: $ conda list | grep python
brotli-python 1.1.0 py310hf71b8c6_3 conda-forge
cf-python 3.19.0 pypi_0 pypi
dnspython 2.7.0 pypi_0 pypi
ipython 8.30.0 py310h06a4308_0
python 3.10.18 h1a3bd86_0
python-dateutil 2.9.0.post0 pyhe01879c_2 conda-forge
python-dotenv 1.0.1 pypi_0 pypi
python-engineio 4.12.2 pypi_0 pypi
python-fastjsonschema 2.20.0 py310h06a4308_0
python-json-logger 3.2.1 py310h06a4308_0
python-slugify 8.0.4 pypi_0 pypi
python-socketio 5.13.0 pypi_0 pypi
python_abi 3.10 2_cp310 conda-forge
types-python-dateutil 2.9.0.20250809 pypi_0 pypiThe job log you link to is in Python 3,12, anyway and not failing because of cf-python dependencies. |
|
@sadielbartholomew you have a mixed environment and you are installing cf-python from PyPI |
|
@sadielbartholomew here is your dependency table for the conda-forge cf-python: which is a solid approach - you installing the latest cf-python from PyPI in a Python 3.10 environment is bound to start a lot of corner case issues eg a numpy>2.3 from PyPI that is incompatible with Python 3.10, an old netCDF4 that may give a lot of headaches and you don't know why etc; as a rule: don't mix (as much as you can) conda-forge packages with PyPI packages, and always build a package against a tested version of Python - did you run the tests for the newly released cf-python 3.19 in a Python 3.10 environment, or at least, a |
|
I'm somewhat bemused as to what's going on here.
|
|
Do you know why Filipe changed it? You can take ownership - and I can help you and Sadie with it - I maintain all the packages I work on, so I assumed you did the same, and changed it for a good reason. |
|
merging this via offline chat with @bnlawrence and @davidhassell = don't worry @sadielbartholomew - we started taking back ownership of the feedstock, see eg conda-forge/cf-python-feedstock#55 (David or I will add you there as well, after Filipe adds us), so we can rebuild the conda-forge package with Python 3.10 support 🍺 |
We can't support Python 3.10 due to dependency on
cf-python, and the conda package is also built withpython_min = 3.11.