Merged
Conversation
Contributor
Author
|
Successfully deployed to the k8s dev cluster in the vegbank namespace and tested there. Merging to dev... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This PR adds
GETendpoints for named places, allowing clients to get this data as:np_codeIt also sneaks in a few minor code comment and OpenAPI doc fixes.
Why
So that clients can get the set of named places registered in VegBank, especially for associating with their own plot observations at upload time ... if we choose to support this.
Previously we only returned named place records associated with specific plot observations, as a nested array field in the plot observation responses.
How
Testing and documentation
vegbankrR package API integration and end-to-end tests for hitting the new endpoints, and confirmed that all tests passDemo
Get one named place record
$ http GET 'http://127.0.0.1:8080/named-places/np.61514'{ "count": 1, "data": [ { "code": "ZION", "description": null, "name": "Zion NP", "np_code": "np.61514", "obs_count": 0, "owner": "US NPS", "rf_label": null, "system": "Geographic Name" } ] }Get the full paginated collection of named places (limit 2)
$ http GET 'http://127.0.0.1:8080/named-places?limit=2'{ "count": 64563, "data": [ { "code": "f", "description": null, "name": "Africa", "np_code": "np.1", "obs_count": 0, "owner": null, "rf_label": "USLC place names", "system": "continent" }, { "code": "fc", "description": null, "name": "Africa, Central", "np_code": "np.2", "obs_count": 0, "owner": null, "rf_label": "USLC place names", "system": "area|country|territory" } ] }