Skip to content

Feature-310: queries Resource Refactor#314

Merged
doulikecookiedough merged 59 commits intodevelopfrom
feature-310-queries-resource
Feb 18, 2026
Merged

Feature-310: queries Resource Refactor#314
doulikecookiedough merged 59 commits intodevelopfrom
feature-310-queries-resource

Conversation

@doulikecookiedough
Copy link
Contributor

Summary of Changes:

  • Deleted queries folder in repo root and added new (resource) folder in /vegbank
  • Added new function (with pytest) to utilities module load_sql which uses importlib.resources to retrieve a sql document with a given resource and path
  • Refactored operator classes which previously used paths to select sql documents to use the queries resource insetad
  • Added pytests for operator classes to new queries resource changes
  • Refactored Dockerfile to remove queries folder COPY statement

#310

…resource, and refactor the operator module 'CommunityClassification', and revised the 'load_sql' pytest
…IES_FOLDER', updating the affected code and revising pytests
… to class overrides by using the 'queries_root' attribute
… attribute is overridden in implementing classes
…x bug in 'CommunityConcept' operator class with incorrect queries attribute
…Concept' operator function 'upload_community_correlations' for incorrect queries attribute
… package test for 'upload_plant_names' function
…est_plant_concept' module and fix bug in 'PlantConcept' operator class
Copy link
Contributor

@RWShelton RWShelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran a couple tests against this in dev-vb-dev both upload and read, no problems with either. This seems to match up with my understanding of how this process works, so it's good to go by my eyes, but someone with a little more expertise in package structure might want to weigh in as well.

@doulikecookiedough
Copy link
Contributor Author

Merging into develop - I will create new issues if we receive further feedback 🙏

@doulikecookiedough doulikecookiedough merged commit 52ccc16 into develop Feb 18, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments