Python "FutureWarnings" in EE2 Standards#19
Python "FutureWarnings" in EE2 Standards#19AliciaBentley-NOAA wants to merge 4 commits intoNCO-HPC:developfrom
Conversation
|
I think this is a sensible addition and should be included. I do think it would be better as a bullet point under Subsection C of the Standards section (interpreted code). Don't forget to open an Issue that corresponds to this PR! |
|
@JacobCarley-NOAA Thanks! That makes sense to me. Would you like us to move the new "FutureWarning" text to Section C (Interpreted Code) after the bullet that says "Python version must be at version 3 or higher."? It would look something like:
|
|
I think that works great. Thanks! |
|
EE2 standards Issue #20 has been created to capture this. |
JacobCarley-NOAA
left a comment
There was a problem hiding this comment.
Changes look good and in the right place. This is a logical update to the standards.
aerorahul
left a comment
There was a problem hiding this comment.
Looks good to me. I left a comment in the issue on a possible way to reduce the occurrences of repeated FutureWarning without suppressing them while developing the software.
This hopefully will yield less repetition in the logs.
As more production packages use Python, we are going to start seeing Python "FutureWarning" messages in operational log files. Python "FutureWarning" messages do not indicate a current problem with the production code–they warn about a Python or Python package incompatibility that may cause jobs to fail when a future version of Python or the Python library is used.
Python "FutureWarning" messages should be considered acceptable during the EE2 Review process and in operational log files. Developers should make an effort to address the underlying cause of "FutureWarning" messages, when possible, to prevent jobs from failing in the future. I'd like the EE2 Standards document updated to reflect this.
Please feel free to suggest changes to the wording that I used in this PR. Thanks!
CC @JacobCarley-NOAA @aerorahul @JustinCooke-NCO