-
Notifications
You must be signed in to change notification settings - Fork 4
Fix total calculation in dashboard #334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@Megha-Dev-19 I just happen to jump in here and I see that it is still a draft, but I want to just mention that is unclear what it is about and it would be great to have tests for the balances to ensure correctness of the displayed amounts (maybe that is a separate effort, but it is an important one for treasury) |
|
Hey @frol, yeah I intent to add the tests and update the chart API, thats why its stil draft |
d30c712 to
84a4a86
Compare
|
@race-of-sloths include |
|
@Megha-Dev-19 Thank you for your contribution! Your pull request is now a part of the Race of Sloths! Current status: executed
Your contribution is much appreciated with a final score of 5! @petersalomonsen received 25 Sloth Points for reviewing and scoring this pull request. We would appreciate your feedback or contribution idea that you can submit here What is the Race of SlothsRace of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow For contributors:
For maintainers:
Feel free to check our website for additional details! Bot commands
|
Tguntenaar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, let's make sure that the backend action actually deployed the API before merging this PR. @Megha-Dev-19
|
@race-of-sloths include 5 |
we can merge it to staging, since backend is already deployed for testing instance, will test once after merging this, and for main, will merge both together. |
11f7f72 to
deba63a
Compare
|
🥁 Score it! @Tguntenaar, please score the PR with |
|
@race-of-sloths score 5 |
Fastnear account API
https://api3.nearblocks.io/v1/account/shitzu.sputnik-dao.nearbalance doesn't includes the staked amount, which the frontend did, so made some changes to add the staked tokens on top of the balance received from the API.Updated backend API to show the staked balance in chart
video.webm
video.webm
video.webm