Skip to content

Conversation

@Megha-Dev-19
Copy link
Collaborator

@Megha-Dev-19 Megha-Dev-19 commented Feb 15, 2025

Fastnear account API https://api3.nearblocks.io/v1/account/shitzu.sputnik-dao.near balance doesn't includes the staked amount, which the frontend did, so made some changes to add the staked tokens on top of the balance received from the API.
Updated backend API to show the staked balance in chart
video.webm
video.webm
video.webm

@frol
Copy link
Member

frol commented Feb 15, 2025

@Megha-Dev-19 I just happen to jump in here and I see that it is still a draft, but I want to just mention that is unclear what it is about and it would be great to have tests for the balances to ensure correctness of the displayed amounts (maybe that is a separate effort, but it is an important one for treasury)

@Megha-Dev-19
Copy link
Collaborator Author

Hey @frol, yeah I intent to add the tests and update the chart API, thats why its stil draft

@Megha-Dev-19 Megha-Dev-19 marked this pull request as ready for review February 23, 2025 18:54
@Megha-Dev-19
Copy link
Collaborator Author

@race-of-sloths include

@race-of-sloths
Copy link

race-of-sloths commented Feb 23, 2025

@Megha-Dev-19 Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
Weekly streak is on the road, smart strategy! Secure your streak with another PR!

Shows inviting banner with latest news.

Shows profile picture for the author of the PR

Current status: executed
Reviewer Score
@petersalomonsen 5

Your contribution is much appreciated with a final score of 5!
You have received 58 (50 base + 15% lifetime bonus) Sloth points for this contribution

@petersalomonsen received 25 Sloth Points for reviewing and scoring this pull request.

We would appreciate your feedback or contribution idea that you can submit here

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths and receive a reward
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

@Tguntenaar Tguntenaar self-requested a review February 24, 2025 11:42
Copy link
Contributor

@Tguntenaar Tguntenaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, let's make sure that the backend action actually deployed the API before merging this PR. @Megha-Dev-19

@Tguntenaar
Copy link
Contributor

@race-of-sloths include 5

@Megha-Dev-19
Copy link
Collaborator Author

Megha-Dev-19 commented Feb 24, 2025

Looks good to me, let's make sure that the backend action actually deployed the API before merging this PR.

we can merge it to staging, since backend is already deployed for testing instance, will test once after merging this, and for main, will merge both together.

@Megha-Dev-19 Megha-Dev-19 merged commit b991916 into staging Feb 24, 2025
21 checks passed
@Megha-Dev-19 Megha-Dev-19 deleted the fix-total-calculation branch February 24, 2025 17:42
@race-of-sloths
Copy link

🥁 Score it!

@Tguntenaar, please score the PR with @race-of-sloths score [1/2/3/5/8/13]. The contributor deserves it.
If no scoring is provided within 24 hours, this PR will be scored as 2 🦥

@petersalomonsen
Copy link
Collaborator

@race-of-sloths score 5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants