Skip to content

Conversation

@andybeet
Copy link
Member

@andybeet andybeet commented Aug 19, 2025

Documentation

  • Formatted older datasets to have same format as newer MDEB datasets
  • Added examples to all older data sets and removed old metadata
  • Updated gettingStarted.rmd to include a data set not being deprecated
  • added alt text to images
  • switched the order of developers
  • typos

@andybeet andybeet mentioned this pull request Aug 19, 2025
@andybeet andybeet requested a review from jmhatch August 19, 2025 20:33
@jmhatch
Copy link
Member

jmhatch commented Aug 20, 2025

@andybeet, looked good! A couple of really minor things,

  • Added periods to to the end of some Description / Details sections (just to make things more consistent, when I noticed)
  • Re-built the documentation after modifying some of the .R files (see bullet above)
  • Reverted back to Bootstrap 3, for now (the pkgdown site looks messed up from the outdated .css when I built it); I started another branch bootstrap_5 to work on this and hopefully fix the formatting issues

I can't remember were we landed. Do you want me to push my edits to this PR? That might be the easiest, and they're all minor.

@andybeet
Copy link
Member Author

Please push changes. So i had issues with bootstap 5 initially. I had to delete the entire docs folder and let pkgdown rebuild from scratch. After that, the site looked good, no problems. Can you show me what issues you are seeing? I wonder if it is just a local issue.

@jmhatch
Copy link
Member

jmhatch commented Aug 20, 2025

Here is what my local build produces,
NEFSCspatial_pkgdown_screenshot

Some of the navbar items are colored incorrectly and the right side of the footer isn't right aligned. The background of the navbar isn't showing up at all (compared to the old site). The text also seems a bit out of sorts in a few places, but maybe that's how it was with the old styling? Not a big deal, just some small formatting issues.

@andybeet
Copy link
Member Author

ah, ok! i see those too.

@jmhatch
Copy link
Member

jmhatch commented Aug 20, 2025

Ok, pushed those minor changes.

@andybeet andybeet merged commit 84c6ba8 into dev Aug 21, 2025
7 checks passed
@jmhatch jmhatch deleted the doc_cleanup branch August 22, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants