Skip to content

remove nersc.org from tls request#15

Merged
dingp merged 6 commits intomainfrom
dingpf/remove_nersc_org_domain
Mar 21, 2026
Merged

remove nersc.org from tls request#15
dingp merged 6 commits intomainfrom
dingpf/remove_nersc_org_domain

Conversation

@dingp
Copy link
Copy Markdown
Contributor

@dingp dingp commented Mar 21, 2026

No description provided.

Copilot AI review requested due to automatic review settings March 21, 2026 17:40
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the tls-acme Helm chart configuration/docs to stop requesting TLS certificates that include the default Spin hostname (i.e., avoid including *.svc.spin.nersc.org in certificate SANs), while keeping the default Spin host as an ingress route.

Changes:

  • Remove the default Spin hostname from the Ingress TLS hosts list so it is excluded from certificate SANs.
  • Update the TLS chart values template, README, and helper script defaults to reflect “user-facing domains only” for certificate requests.
  • Add AGENTS.md contributor guidelines for linting/testing workflows.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
tls-acme/values_template.yaml Clarifies intended separation between ingress hosts and certificate SAN host list in the values template.
tls-acme/templates/ingress.yaml Drops auto-added default Spin hostname from the TLS SAN host list while keeping it as an ingress rule.
tls-acme/README.md Updates behavior description to note default Spin hostname remains routed but excluded from certificate SANs.
tls-acme/prepare-values.sh Adjusts generated domain_list default to exclude the default Spin hostname.
AGENTS.md Adds repo-wide contribution/testing guidance and local lint commands.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dingp dingp merged commit 252f1ca into main Mar 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants