Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the tls-acme Helm chart configuration/docs to stop requesting TLS certificates that include the default Spin hostname (i.e., avoid including *.svc.spin.nersc.org in certificate SANs), while keeping the default Spin host as an ingress route.
Changes:
- Remove the default Spin hostname from the Ingress TLS
hostslist so it is excluded from certificate SANs. - Update the TLS chart values template, README, and helper script defaults to reflect “user-facing domains only” for certificate requests.
- Add
AGENTS.mdcontributor guidelines for linting/testing workflows.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tls-acme/values_template.yaml | Clarifies intended separation between ingress hosts and certificate SAN host list in the values template. |
| tls-acme/templates/ingress.yaml | Drops auto-added default Spin hostname from the TLS SAN host list while keeping it as an ingress rule. |
| tls-acme/README.md | Updates behavior description to note default Spin hostname remains routed but excluded from certificate SANs. |
| tls-acme/prepare-values.sh | Adjusts generated domain_list default to exclude the default Spin hostname. |
| AGENTS.md | Adds repo-wide contribution/testing guidance and local lint commands. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.