added missing quotes to ticket delegation

[fl0wx]

Added missing quotes to ticket delegation. Currently, the ticket creation fails with the following error message:

TASK [icinga.icinga.icinga2 : delegate ticket request to master] ***********************************************************************************************************************************************************************************************************************************************************
changed: [host1.local -> host0.local] => {"changed": true, "cmd": "icinga2 pki ticket --cn \"host1.local --salt XXXXXXXX\"", "delta": "0:00:00.062976", "end": "2023-12-29 11:33:07.761888", "msg": "", "rc": 0, "start": "2023-12-29 11:33:07.698912", "stderr": "", "stderr_lines": [], "stdout": "fc043b935aacd292b742b0aaecd63e9055c16c95", "stdout_lines": ["fc043b935aacd292b742b0aaecd63e9055c16c95"]}

TASK [icinga.icinga.icinga2 : get certificate] *****************************************************************************************************************************************************************************************************************************************************************************
fatal: [host1.local]: FAILED! => {"changed": true, "cmd": "icinga2 pki  request --ticket \"fc043b935aacd292b742b0aaecd63e9055c16c95\" --host \"host0.local\" --port \"5665\" --ca \"/var/lib/icinga2/certs/ca.crt\" --key \"/var/lib/icinga2/certs/host1.local.key\" --trustedcert \"/var/lib/icinga2/certs/trusted-master.crt\"  --cert \"/var/lib/icinga2/certs/host1.local.crt\"", "delta": "0:00:00.130217", "end": "2023-12-29 11:33:09.363278", "msg": "non-zero return code", "rc": 1, "start": "2023-12-29 11:33:09.233061", "stderr": "", "stderr_lines": [], "stdout": "information/cli: Writing CA certificate to file '/var/lib/icinga2/certs/ca.crt'.\ncritical/cli: !!! Invalid ticket for CN 'host1.local'.", "stdout_lines": ["information/cli: Writing CA certificate to file '/var/lib/icinga2/certs/ca.crt'.", "critical/cli: !!! Invalid ticket for CN 'host1.local'."]}

the addition of the new quotes changes the command to an actual working command:

OLD: icinga2 pki ticket --cn "host1.local --salt XXXXXXXX"
NEW: icinga2 pki ticket --cn "host1.local" --salt "XXXXXXXX"

[cla-bot]

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @fl0wx

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.

• If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

[mocdaniel]

Thanks a lot, this slipped our attention.
LGTM! Edit: Please see comment below.

[mocdaniel]

Almost forgot: Could you please add a changelog fragment? This makes it easier for us to track changes, fixes, etc. and attribute them to contributors.

Information on how to do it can be found here, with some recent examples here.

[cla-bot]

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @fl0wx

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.

• If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

[fl0wx]

done :)

[mocdaniel]

@bobapple can you check whether the CLA has been signed successfully?

[fl0wx]

@mocdaniel i signed it just now. can you rerun the check?

[mocdaniel]

Unfortunately, I can't, hence the ping above :) This will get merged after the weekend, probably.

[bobapple]

@cla-bot check

[cla-bot]

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @fl0wx

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.

• If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

[bobapple]

@cla-bot check

[mocdaniel]

Thanks a lot for your contribution @fl0wx!